Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error messaging to Veteran Verification /status endpoint #19467

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

khenson-oddball
Copy link
Contributor

@khenson-oddball khenson-oddball commented Nov 14, 2024

Summary

  • This work is not behind a feature toggle.
  • This change adds error message logic to a new route for getting confirmation of a veteran's Title 38 status. This endpoint returns data from the Lighthouse Veteran Service History and Eligibility API /status endpoint, which will be used to determine if a veteran is eligible to view their Proof of Status card. If the veteran is found to be ineligible, this change provides more detailed information to display to the user to help them understand why and who to contact to correct it, if they choose.
  • Documentation and further logging will be added in a forthcoming PR.
  • I work on the IIR Product team and we currently own this feature.

Related issue(s)

Testing done

  • New code is covered by unit tests
  • There is no old behavior, as this is a completely new implementation.

Screenshots

What areas of the site does it impact?

This change does not impact any areas outside of the newly added files.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

@va-vfs-bot va-vfs-bot temporarily deployed to iir-1210-add-error-messages-to-LH/main/main November 14, 2024 21:04 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants