Add error messaging to Veteran Verification /status endpoint

lib/lighthouse/veteran_verification/constants.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+module VeteranVerification
+  module Constants
+    NOT_FOUND_MESSAGE = [
+      'We’re sorry. There’s a problem with your discharge status records. We can’t provide a Veteran status ' \
+      'card for you right now.',
+      'To fix the problem with your records, call the Defense Manpower Data Center at 800-538-9552 (TTY: 711).' \
+      ' They’re open Monday through Friday, 8:00 a.m. to 8:00 p.m. ET.'
+    ].freeze
+    NOT_ELIGIBLE_MESSAGE = [
+      'Our records show that you’re not eligible for a Veteran status card. To get a Veteran status card, you ' \
+      'must have received an honorable discharge for at least one period of service.',
+      'If you think your discharge status is incorrect, call the Defense Manpower Data Center at 800-538-9552 ' \
+      '(TTY: 711). They’re open Monday through Friday, 8:00 a.m. to 8:00 p.m. ET.'
+    ].freeze
+  end
+end

lib/lighthouse/veteran_verification/service.rb

@@ -2,6 +2,7 @@
 
 require 'common/client/base'
 require 'lighthouse/veteran_verification/configuration'
+require 'lighthouse/veteran_verification/constants'
 require 'lighthouse/service_exception'
 
 module VeteranVerification
@@ -36,12 +37,14 @@ def get_rated_disabilities(icn, lighthouse_client_id = nil, lighthouse_rsa_key_p
     #   see https://developer.va.gov/explore/api/veteran-service-history-and-eligibility/docs
     def get_vet_verification_status(icn, lighthouse_client_id = nil, lighthouse_rsa_key_path = nil, options = {})
       endpoint = 'status'
-      config.get(
+      response = config.get(
         "#{endpoint}/#{icn}",
         lighthouse_client_id,
         lighthouse_rsa_key_path,
         options
       ).body
+
+      transform_response(response)
     rescue => e
       handle_error(e, lighthouse_client_id, endpoint)
     end
@@ -54,5 +57,18 @@ def handle_error(error, lighthouse_client_id, endpoint)
         "#{config.base_api_path}/#{endpoint}"
       )
     end
+
+    def transform_response(response)
+      attributes = response['data']['attributes']
+      return response if attributes['veteran_status'] != 'not confirmed' || attributes.exclude?('not_confirmed_reason')
+
+      response['data']['message'] =
+        if attributes['not_confirmed_reason'] == 'NOT_TITLE_38'
+          VeteranVerification::Constants::NOT_ELIGIBLE_MESSAGE
+        else
+          VeteranVerification::Constants::NOT_FOUND_MESSAGE
+        end
+      response
+    end
   end
 end

spec/controllers/v0/profile/vet_verification_statuses_controller_spec.rb

@@ -73,6 +73,7 @@
         parsed_body = JSON.parse(response.body)
         expect(parsed_body['data']['attributes']['veteran_status']).to eq('not confirmed')
         expect(parsed_body['data']['attributes']['not_confirmed_reason']).to eq('PERSON_NOT_FOUND')
+        expect(parsed_body['data']['message']).to eq(VeteranVerification::Constants::NOT_FOUND_MESSAGE)
       end
     end
   end

spec/lib/lighthouse/veteran_verification/service_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'rails_helper'
+require 'lighthouse/veteran_verification/constants'
 require 'lighthouse/veteran_verification/service'
 require 'lighthouse/service_exception'
 
@@ -65,9 +66,22 @@ def test_error(cassette_path)
         it 'retrieves veteran not confirmed status from the Lighthouse API' do
           VCR.use_cassette('lighthouse/veteran_verification/status/200_not_confirmed_response') do
             response = @service.get_vet_verification_status('1012666182V203559', '', '')
+
             expect(response['data']['id']).to eq('1012666182V203559')
             expect(response['data']['attributes']['veteran_status']).to eq('not confirmed')
             expect(response['data']['attributes']).to have_key('not_confirmed_reason')
+            expect(response['data']['message']).to eq(VeteranVerification::Constants::NOT_ELIGIBLE_MESSAGE)
+          end
+        end
+
+        it 'retrieves veteran not found status from the Lighthouse API' do
+          VCR.use_cassette('lighthouse/veteran_verification/status/200_person_not_found_response') do
+            response = @service.get_vet_verification_status('1012667145V762141', '', '')
+
+            expect(response['data']['id']).to eq(nil)
+            expect(response['data']['attributes']['veteran_status']).to eq('not confirmed')
+            expect(response['data']['attributes']).to have_key('not_confirmed_reason')
+            expect(response['data']['message']).to eq(VeteranVerification::Constants::NOT_FOUND_MESSAGE)
           end
         end