Add missing assets in order to make Storybook work #7
Conversation
| "build-storybook": "build-storybook -s ./stories/assets", | ||
| "deploy-storybook": "storybook-to-ghpages" | ||
| }, | ||
| "storybook-deployer": { |
There was a problem hiding this comment.
Do we need storybook-deployer? According to the docs it's the default: https://github.com/storybooks/storybook-deployer
There was a problem hiding this comment.
Just added the [skip ci] to the commit message in order to make the process faster as we don't need that steep right?
package.json
Outdated
| "test": "react-scripts-ts test --env=jsdom", | ||
| "storybook": "start-storybook -p 6006 -s ./stories/assets", | ||
| "build-storybook": "build-storybook" | ||
| "build-storybook": "build-storybook -s ./stories/assets", |
There was a problem hiding this comment.
do we need to add -o .out to the end of this command? https://github.com/storybooks/storybook-deployer
There was a problem hiding this comment.
According to the docs yes, but looks like it works well now :/
|
Did you want to add the required Travis config to get this happening? 😄 #13 |
|
We can do #13 here yeah, do you know how to do it? Otherwise we can just delay it |
|
@majames any idea of why build is failing? |
|
Looks like it was a random build failure, @majames you happy with merging this? |
|
Approved! Failure was probs my bad dude, when I updated travis and/or coveralls config. |
https://majames.github.io/react-audio-vis 💫