Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing assets in order to make Storybook work #7

Merged
merged 5 commits into from
May 29, 2017
Merged

Add missing assets in order to make Storybook work #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7552716
Add missing assets in order to make Storybook work
zzarcon May 24, 2017
2cad782
Add storybook-deployer
zzarcon May 24, 2017
dd63537
Add missing asset path to storybook-deployer
zzarcon May 24, 2017
c410b1e
Fix assets
zzarcon May 24, 2017
426b955
Merge remote-tracking branch 'origin/master' into chore/add_assets
zzarcon May 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,9 @@
/build
/dist

# static assets
/stories/assets

# misc
.DS_Store
.env
npm-debug.log*
yarn-debug.log*
yarn-error.log*

yarn-error.log*
11 changes: 9 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,23 @@
},
"devDependencies": {
"@kadira/storybook": "^2.21.0",
"@kadira/storybook-deployer": "^1.2.0",
"coveralls": "^2.13.1",
"react-scripts-ts": "^1.4.0",
"styled-components": "^1.4.6",
"typescript": "^2.3.2"
},
"scripts": {
"build": "./node_modules/.bin/tsc",
"build": "tsc",
"test": "react-scripts-ts test --env=jsdom",
"coverage": "yarn run test -- --coverage",
"storybook": "start-storybook -p 6006 -s ./stories/assets",
"build-storybook": "build-storybook"
"build-storybook": "build-storybook -s ./stories/assets",
"deploy-storybook": "storybook-to-ghpages"
},
"storybook-deployer": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need storybook-deployer? According to the docs it's the default: https://github.com/storybooks/storybook-deployer

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added the [skip ci] to the commit message in order to make the process faster as we don't need that steep right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

"gitUsername": "GH Pages Bot",
"gitEmail": "[email protected]",
"commitMessage": "Deploy Storybook to GitHub Pages [skip ci]"
}
}
Empty file added stories/assets/.gitkeep
View file
Open in desktop
Empty file.
Binary file added stories/assets/music.mp3
View file
Open in desktop
Binary file not shown.
39 changes: 38 additions & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,13 @@
version "1.1.0"
resolved "https://registry.yarnpkg.com/@kadira/storybook-channel/-/storybook-channel-1.1.0.tgz#806d1cdf2498d11cce09871a6fd27bbb41ed3564"

"@kadira/storybook-deployer@^1.2.0":
version "1.2.0"
resolved "https://registry.yarnpkg.com/@kadira/storybook-deployer/-/storybook-deployer-1.2.0.tgz#1708f5cb37fa08ab4173b1bd99df6f4717dfae12"
dependencies:
git-url-parse "^6.0.2"
shelljs "^0.7.0"

"@kadira/storybook-ui@^3.10.1":
version "3.11.0"
resolved "https://registry.yarnpkg.com/@kadira/storybook-ui/-/storybook-ui-3.11.0.tgz#a5ccdcc479aa5e08465c58e7df493e37e4b2a14a"
Expand Down Expand Up @@ -2395,6 +2402,19 @@ getpass@^0.1.1:
dependencies:
assert-plus "^1.0.0"

git-up@^2.0.0:
version "2.0.8"
resolved "https://registry.yarnpkg.com/git-up/-/git-up-2.0.8.tgz#24be049c9f0b193481d2df4e016a16530a5f4ef4"
dependencies:
is-ssh "^1.3.0"
parse-url "^1.3.0"

git-url-parse@^6.0.2:
version "6.2.2"
resolved "https://registry.yarnpkg.com/git-url-parse/-/git-url-parse-6.2.2.tgz#be49024e14b8487553436b4572b8b439532fa871"
dependencies:
git-up "^2.0.0"

glob-base@^0.3.0:
version "0.3.0"
resolved "https://registry.yarnpkg.com/glob-base/-/glob-base-0.3.0.tgz#dbb164f6221b1c0b1ccf82aea328b497df0ea3c4"
Expand Down Expand Up @@ -2884,6 +2904,12 @@ is-retry-allowed@^1.0.0:
version "1.1.0"
resolved "https://registry.yarnpkg.com/is-retry-allowed/-/is-retry-allowed-1.1.0.tgz#11a060568b67339444033d0125a61a20d564fb34"

is-ssh@^1.3.0:
version "1.3.0"
resolved "https://registry.yarnpkg.com/is-ssh/-/is-ssh-1.3.0.tgz#ebea1169a2614da392a63740366c3ce049d8dff6"
dependencies:
protocols "^1.1.0"

is-stream@^1.0.0, is-stream@^1.0.1, is-stream@^1.1.0:
version "1.1.0"
resolved "https://registry.yarnpkg.com/is-stream/-/is-stream-1.1.0.tgz#12d4a3dd4e68e0b79ceb8dbc84173ae80d91ca44"
Expand Down Expand Up @@ -4004,6 +4030,13 @@ parse-json@^2.2.0:
dependencies:
error-ex "^1.2.0"

parse-url@^1.3.0:
version "1.3.7"
resolved "https://registry.yarnpkg.com/parse-url/-/parse-url-1.3.7.tgz#636cb6e32b88255c704e30ab4349676703267af8"
dependencies:
is-ssh "^1.3.0"
protocols "^1.4.0"

parse5@^1.5.1:
version "1.5.1"
resolved "https://registry.yarnpkg.com/parse5/-/parse5-1.5.1.tgz#9b7f3b0de32be78dc2401b17573ccaf0f6f59d94"
Expand Down Expand Up @@ -4409,6 +4442,10 @@ prop-types@^15.5.4, prop-types@^15.5.7, prop-types@~15.5.7:
dependencies:
fbjs "^0.8.9"

protocols@^1.1.0, protocols@^1.4.0:
version "1.4.5"
resolved "https://registry.yarnpkg.com/protocols/-/protocols-1.4.5.tgz#21de1f441c4ef7094408ed9f1c94f7a114b87557"

proxy-addr@~1.1.3:
version "1.1.4"
resolved "https://registry.yarnpkg.com/proxy-addr/-/proxy-addr-1.1.4.tgz#27e545f6960a44a627d9b44467e35c1b6b4ce2f3"
Expand Down Expand Up @@ -5038,7 +5075,7 @@ [email protected], shallowequal@^0.2.2:
dependencies:
lodash.keys "^3.1.2"

shelljs@^0.7.4:
shelljs@^0.7.0, shelljs@^0.7.4:
version "0.7.7"
resolved "https://registry.yarnpkg.com/shelljs/-/shelljs-0.7.7.tgz#b2f5c77ef97148f4b4f6e22682e10bba8667cff1"
dependencies:
Expand Down