Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: replace q2-types-genomics with q2-types #8

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

misialq
Copy link
Contributor

@misialq misialq commented Feb 23, 2024

This PR updates q2-sourmash to use the types defined in q2-types rather than q2-types-genomics, after their recent move (qiime2/q2-types#309).

@misialq
Copy link
Contributor Author

misialq commented Feb 23, 2024

Hey @gregcaporaso, could you have a look at this small one? 🙏

@gregcaporaso gregcaporaso self-assigned this Feb 23, 2024
@gregcaporaso gregcaporaso merged commit b2d2ff2 into dib-lab:main Feb 23, 2024
@gregcaporaso
Copy link
Collaborator

I tested these updated imports in 2024.2 shotgun environment and all looks good. Thanks @misialq!

@misialq misialq deleted the remove-types-genomics branch February 23, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants