Add kubeconfig expiration option for credentials #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steffen Exler <[email protected]>
Signed-off-by: Steffen Exler <[email protected]>
|
I tested the code changes, and it is working well for me.
But I did not know how to properly add unit test for it. Maybe someone could give me a hint here. |
Michiel87
approved these changes
Jan 16, 2025
|
@andrewsomething the documentation is now added. |
andrewsomething
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce an option to specify the expiration time for kubeconfig credentials, enhancing the flexibility of credential management. Remove the default value for this option to allow explicit configuration.