Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubeconfig expiration option for credentials #1306

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Add kubeconfig expiration option for credentials #1306

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
51eeee3
feat(kubernetes): add kubeconfig expiration option for credentials
linuxluigi Jan 14, 2025
b6ffc73
refactor(kubernetes): remove default value for kubeconfig expiration
linuxluigi Jan 15, 2025
f6adff8
Merge branch 'main' into chore/kubeconfig
linuxluigi Jan 20, 2025
c2c7015
docs(kubernetes): add kubeconfig_expire_seconds option to documentation
linuxluigi Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion digitalocean/kubernetes/resource_kubernetes_cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,12 @@ func ResourceDigitalOceanKubernetesCluster() *schema.Resource {
Optional: true,
Default: false,
},

"kubeconfig_expire_seconds": {
Type: schema.TypeInt,
Optional: true,
ValidateFunc: validation.IntAtLeast(0),
},
},

Timeouts: &schema.ResourceTimeout{
Expand Down Expand Up @@ -424,7 +430,10 @@ func digitaloceanKubernetesClusterRead(
}
}
if expiresAt.IsZero() || expiresAt.Before(time.Now()) {
creds, _, err := client.Kubernetes.GetCredentials(context.Background(), cluster.ID, &godo.KubernetesClusterCredentialsGetRequest{})
expireSeconds := d.Get("kubeconfig_expire_seconds").(int)
creds, _, err := client.Kubernetes.GetCredentials(context.Background(), cluster.ID, &godo.KubernetesClusterCredentialsGetRequest{
ExpirySeconds: &expireSeconds,
})
if err != nil {
return diag.Errorf("Unable to fetch Kubernetes credentials: %s", err)
}
Expand Down
Loading