new(option) select option for icons

dimitropoulos · Aug 11, 2021 · 33412e9 · 33412e9
1 parent 300862a
commit 33412e9
Show file tree

Hide file tree

Showing 28 changed files with 96 additions and 64 deletions.
diff --git a/README.md b/README.md
diff --git a/components/select.ts b/components/select.ts
@@ -1,5 +1,5 @@
 import { ComponentInfo } from '../entities';
-import { checkmark, indexByOptionId } from '../utils';
+import { checkmark, indexByOptionId, stringArray } from '../utils';
 
 export const select: ComponentInfo = {
   cannonicalName: 'Select',
@@ -37,5 +37,11 @@ export const select: ComponentInfo = {
       optionId: 'groupable',
       ...checkmark,
     },
+    {
+      criteria: 'Has out-of-the-box (i.e. props) support for start or end icons (or can easily be composed with icons and has examples of such on the docs).',
+      name: 'Icons',
+      optionId: 'icons',
+      ...stringArray,
+    },
   ]),
 };
diff --git a/entities.ts b/entities.ts
@@ -123,6 +123,7 @@ export interface Select extends BaseComponent {
     disabledOptions: boolean;
     filterable: boolean;
     groupable: boolean;
+    icons: ('composable' | 'end' | 'start')[];
   };
 }
 

diff --git a/frameworks/antDesign.ts b/frameworks/antDesign.ts
@@ -91,6 +91,7 @@ export const antDesign: Framework = {
         disabledOptions: true,
         filterable: true,
         groupable: true,
+        icons: ['end'],
       },
     },
     {

diff --git a/frameworks/atlaskit.ts b/frameworks/atlaskit.ts
@@ -76,6 +76,7 @@ export const atlaskit: Framework = {
         disabledOptions: false,
         filterable: true,
         groupable: true,
+        icons: [],
       },
     },
     {

diff --git a/frameworks/blueprint.ts b/frameworks/blueprint.ts
@@ -52,6 +52,7 @@ export const blueprint: Framework = {
         disabledOptions: true,
         filterable: true,
         groupable: true,
+        icons: [],
       },
     },
     {

diff --git a/frameworks/carbonDesign.ts b/frameworks/carbonDesign.ts
@@ -50,6 +50,7 @@ export const carbonDesign: Framework = {
         disabledOptions: true,
         filterable: false,
         groupable: true,
+        icons: [],
       },
     },
     {

diff --git a/frameworks/chakraUI.ts b/frameworks/chakraUI.ts
@@ -67,6 +67,7 @@ export const chakra: Framework = {
         disabledOptions: true,
         filterable: false,
         groupable: false,
+        icons: [],
       },
     },
     {

diff --git a/frameworks/elasticUI.ts b/frameworks/elasticUI.ts
@@ -62,6 +62,7 @@ export const elasticUI: Framework = {
         disabledOptions: true,
         filterable: false,
         groupable: false,
+        icons: ['composable'],
       },
     },
     {

diff --git a/frameworks/element.ts b/frameworks/element.ts
@@ -72,6 +72,7 @@ export const element: Framework = {
         disabledOptions: true,
         filterable: true,
         groupable: true,
+        icons: [],
       },
     },
     {

diff --git a/frameworks/elementalUI.ts b/frameworks/elementalUI.ts
@@ -47,6 +47,7 @@ export const elementalUI: Framework = {
         disabledOptions: false,
         filterable: false,
         groupable: true,
+        icons: [],
       },
     },
   ],

diff --git a/frameworks/evergreen.ts b/frameworks/evergreen.ts
@@ -58,6 +58,7 @@ export const evergreen: Framework = {
         disabledOptions: true,
         filterable: true,
         groupable: true,
+        icons: ['start'],
       },
     },
     {

diff --git a/frameworks/fluentUI.ts b/frameworks/fluentUI.ts
@@ -81,6 +81,7 @@ export const fluentUI: Framework = {
         disabledOptions: true,
         filterable: true,
         groupable: true,
+        icons: ['composable'],
       },
     },
     {

diff --git a/frameworks/gestalt.ts b/frameworks/gestalt.ts
@@ -52,6 +52,7 @@ export const gestalt: Framework = {
         disabledOptions: true,
         filterable: false,
         groupable: false,
+        icons: [],
       },
     },
     {

diff --git a/frameworks/grommet.ts b/frameworks/grommet.ts
@@ -38,6 +38,7 @@ export const grommet: Framework = {
         disabledOptions: true,
         filterable: false,
         groupable: false,
+        icons: [],
       },
     },
     {

diff --git a/frameworks/materialUI.ts b/frameworks/materialUI.ts
@@ -74,13 +74,14 @@ export const materialUI: Framework = {
     {
       componentId: 'select',
       componentName: 'Select',
-      componentURL: `${frameworkHomepage}/docs/#select/select-component`,
+      componentURL: `${frameworkHomepage}/components/selects`,
       options: {
         async: true,
         disabled: true,
         disabledOptions: true,
         filterable: false,
         groupable: true,
+        icons: ['composable'],
       },
     },
     {

diff --git a/frameworks/onsenUI.ts b/frameworks/onsenUI.ts
@@ -38,6 +38,7 @@ export const onsenUI: Framework = {
         disabledOptions: true,
         filterable: false,
         groupable: false,
+        icons: [],
       },
     },
     {

diff --git a/frameworks/orbit.ts b/frameworks/orbit.ts
@@ -40,13 +40,14 @@ export const orbit: Framework = {
     {
       componentId: 'select',
       componentName: 'Select',
-      componentURL: `${frameworkHomepage}/docs/#select/select-component`,
+      componentURL: `${frameworkHomepage}/components/select`,
       options: {
         async: false,
         disabled: true,
         disabledOptions: true,
         filterable: false,
         groupable: false,
+        icons: ['start', 'end'],
       },
     },
   ],

diff --git a/frameworks/primeReact.ts b/frameworks/primeReact.ts
@@ -38,6 +38,7 @@ export const primeReact: Framework = {
         disabledOptions: true,
         filterable: true,
         groupable: true,
+        icons: ['composable'],
       },
     },
     {

diff --git a/frameworks/quasar.ts b/frameworks/quasar.ts
@@ -72,6 +72,7 @@ export const quasar: Framework = {
         disabledOptions: true,
         filterable: true,
         groupable: false,
+        icons: [],
       },
     },
     {

diff --git a/frameworks/reactBootstrap.ts b/frameworks/reactBootstrap.ts
@@ -47,6 +47,7 @@ export const reactBootstrap: Framework = {
         disabledOptions: true,
         filterable: true,
         groupable: true,
+        icons: [],
       },
     },
     {

diff --git a/frameworks/reactMD.ts b/frameworks/reactMD.ts
@@ -38,6 +38,7 @@ export const reactMD: Framework = {
         disabledOptions: false,
         filterable: false,
         groupable: false,
+        icons: ['start', 'end'],
       },
     },
     {

diff --git a/frameworks/reactToolbox.ts b/frameworks/reactToolbox.ts
@@ -52,6 +52,7 @@ export const reactToolbox: Framework = {
         disabledOptions: true,
         filterable: false,
         groupable: false,
+        icons: [],
       },
     },
     {

diff --git a/frameworks/ringUI.ts b/frameworks/ringUI.ts
@@ -72,6 +72,7 @@ export const ringUI: Framework = {
         disabledOptions: true,
         filterable: true,
         groupable: false,
+        icons: [],
       },
     },
     {

diff --git a/frameworks/semanticUI.ts b/frameworks/semanticUI.ts
@@ -38,6 +38,7 @@ export const semanticUI: Framework = {
         disabledOptions: true,
         filterable: true,
         groupable: false,
+        icons: ['composable'],
       },
     },
     {

diff --git a/frameworks/smoothUI.ts b/frameworks/smoothUI.ts
@@ -47,6 +47,7 @@ export const smoothUI: Framework = {
         disabledOptions: true,
         filterable: false,
         groupable: false,
+        icons: [],
       },
     },
     {

diff --git a/frameworks/zendesk.ts b/frameworks/zendesk.ts
@@ -72,6 +72,7 @@ export const zendesk: Framework = {
         disabledOptions: true,
         filterable: false,
         groupable: false,
+        icons: ['start'],
       },
     },
     {

diff --git a/website/FrameworkStatistics.tsx b/website/FrameworkStatistics.tsx
@@ -34,10 +34,10 @@ const Framework: FC<FrameworkType> = ({
         </Link>
       </TableCell>
 
-      <TableCell>{repoInfo?.stargazers_count.toLocaleString() ?? noValue}</TableCell>
-      <TableCell>{repoInfo?.forks_count.toLocaleString() ?? noValue}</TableCell>
-      <TableCell>{repoInfo?.open_issues_count.toLocaleString() ?? noValue}</TableCell>
-      <TableCell>{repoInfo?.license?.name.replace(/ License/, '') ?? noValue}</TableCell>
+      <TableCell>{repoInfo?.stargazers_count?.toLocaleString() ?? noValue}</TableCell>
+      <TableCell>{repoInfo?.forks_count?.toLocaleString() ?? noValue}</TableCell>
+      <TableCell>{repoInfo?.open_issues_count?.toLocaleString() ?? noValue}</TableCell>
+      <TableCell>{repoInfo?.license?.name?.replace(/ License/, '') ?? noValue}</TableCell>
     </TableRow>
   );
 };