fix missing unlocking of ratelimit bucket

disgoorg · Jun 11, 2022 · d040af9 · d040af9
1 parent c706efb
commit d040af9
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/rest/rest_rate_limiter_impl.go b/rest/rest_rate_limiter_impl.go
@@ -69,10 +69,14 @@ func (l *rateLimiterImpl) doCleanup() {
 	before := len(l.buckets)
 	now := time.Now()
 	for hash, b := range l.buckets {
-		if b.mu.TryLock() && b.Reset.Before(now) {
+		if !b.mu.TryLock() {
+			continue
+		}
+		if b.Reset.Before(now) {
 			l.Logger().Debugf("cleaning up bucket, Hash: %s, ID: %s, Reset: %s", hash, b.ID, b.Reset)
 			delete(l.buckets, hash)
 		}
+		b.mu.Unlock()
 	}
 	if before != len(l.buckets) {
 		l.Logger().Debugf("cleaned up %d rate limit buckets", before-len(l.buckets))