Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scala to 2.13.12 #42

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Conversation

valencik
Copy link
Contributor

This PR bumps the version of Scala to 2.13.12.

Without this, I was running into an error on sbt run:

error: scala.reflect.internal.FatalError:                                                                                                                                  
  bad constant pool index: 0 at pos: 48445
...
Error compiling the sbt component 'compiler-bridge_2.13'

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@daddykotex
Copy link
Contributor

Thanks Andrew!

Without this, I was running into an error on sbt run:

Do you mean that you can't compile on older version, like the one that was set before?

@daddykotex
Copy link
Contributor

I'll merge even w/o the CLA, as there is no IP involved in such a version bump

@daddykotex daddykotex merged commit cb6badb into disneystreaming:main Dec 15, 2023
2 of 3 checks passed
daddykotex added a commit that referenced this pull request Dec 15, 2023
This will avoid that our contributors have to spend time on
things like: #42
@valencik
Copy link
Contributor Author

Thanks Andrew!

Without this, I was running into an error on sbt run:

Do you mean that you can't compile on older version, like the one that was set before?

As in a brand new sbt new disneystreaming/smithy4s.g8 was failing on sbt run until I bumped the scala version manually.
But yes, compile also fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants