Special Diggers #3209
Open
Special Diggers #3209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Creature list needs to be updated when the command is used. Possibly the code to start the list is at Rewriting this part and calling a list refresh when changing roaming status should also fix #3364 |
This was referenced Oct 16, 2024
Loobinex
reviewed
Oct 28, 2024
| @@ -855,7 +860,7 @@ TbBool parse_creaturemodel_attributes_blocks(long crtr_model,char *buf,long len, | |||
| game.conf.crtr_conf.spectator_breed = crtr_model; | |||
| } | |||
| // Set creature start states based on the flags | |||
| if ((crconf->model_flags & CMF_IsSpecDigger) != 0) | |||
| if ((crconf->model_flags & (CMF_IsSpecDigger|CMF_IsDiggingCreature)) != 0) | |||
There was a problem hiding this comment.
Do the evil_start_state and good_start_state also need to be cleaned up here?
There was a problem hiding this comment.
how so? good in this context should technically be roaming but think it's fine as is
Loobinex
reviewed
Oct 28, 2024
| @@ -1210,6 +1209,7 @@ TbBool cmd_exec(PlayerNumber plyr_idx, char *msg) | |||
| } | |||
| } | |||
| } | |||
| //todo replace with any on digger_list | |||
There was a problem hiding this comment.
Did you forget this, or is this for a future PR?
There was a problem hiding this comment.
it's just for cheats, so yeah could be tackled at some point but really not critical at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.