Include ffmpeg in CMake build #3683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also fix a build error in bflib_fmvids.cpp. This file includes local headers before C/C++ standard headers, so that our true/false definitions conflict with the ones in C++. This problem only occurs in std::optional when you enable C++17. The best way to fix this should be removing our true/false definitions since they are provided in stdbool.h in C99. Also remove our useless NULL definition. Type: New Feature Change-Id: I7435c628fe970e402ef8fdcf2051385c88689318
Per-file warning treatment is suitable to be put within the file. Type: Code Improvement Change-Id: I6957f0e29f49865049642be111cda2bbf63d455a
Loobinex
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The best way to fix this should be removing our true/false definitions since they are provided in stdbool.h in C99.
Also remove our useless NULL definition.
Type: New Feature
Change-Id: I7435c628fe970e402ef8fdcf2051385c88689318