Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include ffmpeg in CMake build #3683

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Include ffmpeg in CMake build #3683

merged 2 commits into from
Nov 16, 2024

Commits on Nov 16, 2024

  1. Include ffmpeg in CMake build 

    * Also fix a build error in bflib_fmvids.cpp.
This file includes local headers before C/C++ standard headers, so that
our true/false definitions conflict with the ones in C++.
This problem only occurs in std::optional when you enable C++17.

The best way to fix this should be removing our true/false definitions
since they are provided in stdbool.h in C99.

Also remove our useless NULL definition.

Type: New Feature
Change-Id: I7435c628fe970e402ef8fdcf2051385c88689318
    @Linvail
    Linvail committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    fc35299 View commit details
    Browse the repository at this point in the history

  2. Make all warnings into errors in CMake 

    Per-file warning treatment is suitable to be put within the file.

Type: Code Improvement
Change-Id: I6957f0e29f49865049642be111cda2bbf63d455a
    @Linvail
    Linvail committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    33f60c6 View commit details
    Browse the repository at this point in the history