DEVEX-2461 Noble in NF pipelines by default #1435
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhrvol
commented
Feb 6, 2025
| if build_project_id is None: | ||
| parser.error( | ||
| "Can't create an applet without specifying a destination project; please use the -d/--destination flag to explicitly specify a project") | ||
|
|
||
| nf_builder_job = dxpy.DXApp(name=get_importer_name()).run(app_input=input_hash, project=build_project_id, | ||
| nf_builder_job = dxpy.DXApplet("applet-GyXBgzj01xy03BB454gXJxP8").run(applet_input=input_hash, project=build_project_id, |
There was a problem hiding this comment.
This will be changed back to the NPI after we release it (NPI), however for testing I needed to change it to my applet.
Note that NPI release does not break anything, however if we release dx-toolkit without NPI, it will break dx-toolkit.
wormsik
reviewed
Feb 9, 2025
Co-authored-by: Jan Dvorsky <[email protected]>
Co-authored-by: Jan Dvorsky <[email protected]>
Co-authored-by: jsitarova-dnanexus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed default ubuntu version for NF applets to 24.04, also refactored the way extra args are handled