Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1147 include npm lint #1149

Merged
merged 2 commits into from
Dec 4, 2024
Merged

#1147 include npm lint #1149

merged 2 commits into from
Dec 4, 2024

Conversation

akaiap
Copy link
Collaborator

@akaiap akaiap commented Nov 20, 2024

Regarding #1147 -- Includes npm lint in the GitHub Action CI script. Running the lint checker will help catch formatting issues on an ongoing basis.

@akaiap
Copy link
Collaborator Author

akaiap commented Nov 20, 2024

The job failed due to two errors in the setup-handlers.js file:

Line 117: Trailing spaces are not allowed.
Line 137: Missing semicolon.

npm lint works!

Copy link
Owner

@dondi dondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and pleasant surprise there with the lint output integration! As mentioned in the meeting, let’s go ahead and simulate an “error-and-fix” cycle by having you fix the lint errors on this branch, then we can merge

@akaiap
Copy link
Collaborator Author

akaiap commented Nov 29, 2024

Corrected the trailing spaces and missing the semicolon in web-client/public/js/setup-handlers.js, according npm lint.
Ready to be merged!

Copy link
Owner

@dondi dondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏽

@dondi dondi merged commit 079811e into beta Dec 4, 2024
1 check passed
@dondi dondi deleted the #1147-include-npm-lin branch December 4, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants