Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1147 include npm lint #1149

Merged
merged 2 commits into from
Dec 4, 2024
Merged

#1147 include npm lint #1149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cec362
Add npm lint step to GitHub Actions workflow
akaiap Nov 20, 2024
ebac79b
correcting trailing spaces and missing semicolon according to npm lint
akaiap Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/node.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ jobs:
cache: 'npm'

- run: npm ci
- run: npm run lint
- run: npm run build --if-present
- run: npm test

Expand Down
4 changes: 2 additions & 2 deletions web-client/public/js/setup-handlers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export const setupHandlers = grnState => {

const explicitlySetStyle = element => {
const cssStyleDeclarationComputed = window.getComputedStyle(element);
const computedStyleObj = {};
const computedStyleObj = {};


for (let i = 0; i < cssStyleDeclarationComputed.length; i++) {
Expand All @@ -134,7 +134,7 @@ export const setupHandlers = grnState => {
}

if (computedStyleObj) {
Object.assign(element.style, computedStyleObj)
Object.assign(element.style, computedStyleObj);
}
};

Expand Down