-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SafeArea adjustments #23729
Merged
Merged
Fix SafeArea adjustments #23729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
commented
Jul 19, 2024
/rebase |
github-actions
bot
force-pushed
the
adjust_safearea
branch
from
August 9, 2024 17:46
90cbdab
to
e5bf25f
Compare
PureWeen
force-pushed
the
adjust_safearea
branch
from
August 14, 2024 19:34
e5bf25f
to
aeaf700
Compare
/rebase |
github-actions
bot
force-pushed
the
adjust_safearea
branch
from
August 19, 2024 18:49
aeaf700
to
d4947c9
Compare
mattleibow
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested a bunch of things, and it seems to work as I would expect.
rmarinho
pushed a commit
that referenced
this pull request
Sep 5, 2024
PureWeen
added a commit
that referenced
this pull request
Sep 5, 2024
samhouts
added
the
fixed-in-net8.0-nightly
This may be available in a nightly release!
label
Sep 5, 2024
samhouts
added
the
fixed-in-net9.0-nightly
This may be available in a nightly release!
label
Oct 1, 2024
samhouts
added
fixed-in-9.0.0-rc.2.24503.2
and removed
fixed-in-net9.0-nightly
This may be available in a nightly release!
fixed-in-net8.0-nightly
This may be available in a nightly release!
labels
Oct 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR relates to some issues found here #22476 when trying to layout a Button when it's inside a layout that is partly inside the safearea.
The problem we found is that the
MauiView
returns a size fromSizeThatFits
that doesn't include theSafeAreaInsets
. The arrange pass insets itsBounds
and passes this value toCrossPlatformArrange
but theBounds
being used is the size of the children not including theSafeAreaInsets
which means the bounds used for arranging is wrong.You can see from the screenshots below that the
VSL
surrounding the the entry gets arranged incorrectlyComparison
Given the following
XAML
Before
After
Issues Fixed
Fixes #24246