Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context menu styling + fixes #461

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

xoascf
Copy link
Collaborator

@xoascf xoascf commented Nov 6, 2022

WIP!!

Update of some commits that were on hold since 2021: 6493181 dab0c31 WINDOWS TILING FEATURE FOR A DIFFERENT PR NOW!!

Taken mainly from an additional patch of July 2022; context menu styling: xoascf@6c4e6ce, and others of 2023...

@xoascf xoascf linked an issue Dec 19, 2022 that may be closed by this pull request
@dremin
Copy link
Owner

dremin commented Jan 15, 2023

@xoascf Are any of these PRs in draft status ready to be looked at? I had assumed that you were still working on them but I might be wrong.

@xoascf
Copy link
Collaborator Author

xoascf commented Jan 17, 2023

@dremin I'll try to finish it again this week 😅
Man, time goes by so fast...

@xoascf xoascf changed the title Context menu fixes Context menu fixes and styling Jan 17, 2023
@dremin
Copy link
Owner

dremin commented Feb 3, 2023

Ran into a couple issues testing this:

  • The styling of context menus doesn't seem to be quite right
    Screenshot 2023-02-02 at 11 02 04 PM

  • Tile horizontally seems broken?
    Screenshot 2023-02-02 at 11 01 55 PM

  • Undo doesn't seem to restore the window show style (i.e., maximized windows are resized to fill the screen but are not in the 'maximized' state).

    • You can reference ManagedShell for a way to do this - this code to get the current state, and this code to restore it.

@som3rando
Copy link
Contributor

Also undoing sometimes causes retrobar to crash
crash log.log

@1280px 1280px mentioned this pull request Mar 9, 2023
@xoascf xoascf force-pushed the context-menu-fixes branch 2 times, most recently from 451062d to 9f401a0 Compare March 21, 2023 05:39
@xoascf xoascf changed the title Context menu fixes and styling Context menu styling + tile and cascade features Mar 21, 2023
@xoascf xoascf force-pushed the context-menu-fixes branch from 9f401a0 to 16625af Compare March 24, 2023 00:19
@xoascf xoascf mentioned this pull request Mar 30, 2023
@xoascf xoascf force-pushed the context-menu-fixes branch 2 times, most recently from 3b916bf to 07ae470 Compare April 25, 2023 21:11
@som3rando
Copy link
Contributor

I found a few issues running this fork
On windows 11 insider (build 25314.1010) the undo feature is broken instead of undoing it opens a empty explorer window that is not removable until explorer shuts down(on windows 10 its fine).
log1.log
https://youtu.be/x9luV5QVoYU
On windows 7 and 8 the undo feature is also broken but still semi funktional it does it job but it returns 2 of 3 windows back to the original state.
log2.log
https://youtu.be/-6NjJvGQQIs

@xoascf xoascf force-pushed the context-menu-fixes branch from 07ae470 to 4bb2822 Compare June 13, 2023 06:42
@xoascf xoascf force-pushed the context-menu-fixes branch from 4bb2822 to ced935c Compare June 21, 2023 19:12
@xoascf xoascf force-pushed the context-menu-fixes branch from ced935c to 275be69 Compare July 26, 2023 06:37
@xoascf xoascf force-pushed the context-menu-fixes branch from 275be69 to 2160687 Compare January 15, 2024 02:03
@xoascf xoascf force-pushed the context-menu-fixes branch from 2160687 to 085e57e Compare February 22, 2024 04:16
@xoascf xoascf force-pushed the context-menu-fixes branch from 085e57e to 4eec4df Compare April 23, 2024 02:53
@xoascf xoascf force-pushed the context-menu-fixes branch from 4eec4df to b9945ad Compare April 28, 2024 08:23
@xoascf xoascf changed the title Context menu styling + tile and cascade features Context menu styling + fixes Apr 28, 2024
@xoascf xoascf mentioned this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue/Request] Change right click menus to current theme
3 participants