Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick Gh 15187 into dremio 24.3 12 #47

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Cherry pick Gh 15187 into dremio 24.3 12 #47

merged 3 commits into from
Sep 8, 2023

Conversation

lriggs
Copy link

@lriggs lriggs commented Sep 7, 2023

rtadepalli and others added 3 commits September 7, 2023 11:21
@rtadepalli @lriggs
apacheGH-15187: [Java] Made reader initialization lazy and added ne…
c795890 
…w `getTransferPair()` function that takes in a `Field` type (apache#34424)

This PR closes apache#15187. `FieldReader` is being allocated directly in the constructor today, and this PR changes it such that the initialization becomes lazy. Additionally, a new function `getTransferPair(Field, Allocator)` is introduced so that a new `Field` method is not constructed each time `getTransferPair` is called on the Vector.

1. Introduce a new `getTransferPair` method.
2. Make initializing `FieldReader` lazy.

Yes, some tests have been added to verify these changes.

I am not 100% sure if there are any user facing changes.

There should not be any breaking changes.
* Closes: apache#15187

Authored-by: Ramasai <[email protected]>
Signed-off-by: David Li <[email protected]>
@lriggs
Fix import
e7be1ed
@lriggs
Fix imports
be14272
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

prashanthbdremio
prashanthbdremio approved these changes Sep 8, 2023
View reviewed changes
Copy link

@prashanthbdremio prashanthbdremio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cherry picking this Logan! changes look good to me. Whats the next step once the build of jars succeeds? Is there a basic validation test that needs to pass when arrow jars are updated? thanks!

@lriggs
Copy link
Author

lriggs commented Sep 8, 2023

For testing I think the standard dremio checkin tests and maybe a quick tpcds test would be enough for this change. This is more detailed but I don't think we need to do it all for this small of a change. https://dremio.atlassian.net/wiki/spaces/eng/pages/2068382007/Arrow+upgrade+test+plan

@lriggs lriggs merged commit c2ad17b into dremio_24.3_12.0 Sep 8, 2023
22 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashanthbdremio prashanthbdremio prashanthbdremio approved these changes

Assignees
No one assigned
Labels
awaiting review Component: Java
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lriggs @prashanthbdremio @rtadepalli