Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick Gh 15187 into dremio 24.3 12 #47

Merged
merged 3 commits into from
Sep 8, 2023

Commits on Sep 7, 2023

  1. apacheGH-15187: [Java] Made reader initialization lazy and added ne…

    …w `getTransferPair()` function that takes in a `Field` type (apache#34424)
    
    This PR closes apache#15187. `FieldReader` is being allocated directly in the constructor today, and this PR changes it such that the initialization becomes lazy. Additionally, a new function `getTransferPair(Field, Allocator)` is introduced so that a new `Field` method is not constructed each time `getTransferPair` is called on the Vector.
    
    1. Introduce a new `getTransferPair` method.
    2. Make initializing `FieldReader` lazy.
    
    Yes, some tests have been added to verify these changes.
    
    I am not 100% sure if there are any user facing changes.
    
    There should not be any breaking changes.
    * Closes: apache#15187
    
    Authored-by: Ramasai <[email protected]>
    Signed-off-by: David Li <[email protected]>
    rtadepalli authored and lriggs committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    c795890 View commit details
    Browse the repository at this point in the history
  2. Fix import

    lriggs committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    e7be1ed View commit details
    Browse the repository at this point in the history
  3. Fix imports

    lriggs committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    be14272 View commit details
    Browse the repository at this point in the history