Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to module #106

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Convert to module #106

merged 4 commits into from
Oct 16, 2024

Conversation

markhughes
Copy link
Collaborator

@markhughes markhughes commented Sep 30, 2024

This is the "mega update" to make droppy more maintainable, as I've had a lot of struggles myself keep it up to date due to its old syntax.

Changes include:

  • Converting to new modules syntax
  • Moved to Node v20
  • Move to new ESLint ecosystem

Todo:

  • Convert client to module
  • Give client its own a build step, so we can use imports, perhaps with webpack so we can use treeshaking, etc.

What are the changes and their implications?

Checklist

  • Changes covered by tests (tests added if needed)
  • PR submitted to droppyjs.com for any user facing changes

@markhughes markhughes changed the title Feat/convert to module Convert to module Sep 30, 2024
@markhughes markhughes marked this pull request as draft September 30, 2024 09:17
packages/server/lib/services/filetree.js Fixed Show fixed Hide fixed
packages/server/lib/services/server.js Fixed Show fixed Hide fixed
packages/server/lib/services/utils.js Fixed Show fixed Hide fixed
packages/server/lib/services/utils.js Fixed Show fixed Hide fixed
packages/server/lib/services/utils.js Fixed Show fixed Hide fixed
@markhughes markhughes marked this pull request as ready for review October 16, 2024 01:49
@markhughes markhughes merged commit 5ef0590 into canary Oct 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant