Fix bcs kwarg
#123
Merged
Fix bcs kwarg
#123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludgerpaehler
added a commit
that referenced
this pull request
Mar 13, 2024
* Update docker_development.rst * Automatically launch the virtual environment, and install the editable version of HydroGym into it. * Remove the unused Icepack install, which messes with pip's ability to resolve package versions. * Add dedicated subpage to document the testing of HydroGym for package developers. * Adjust the list of authors to the more generic HydroGym Developers as authors * Bug fix, @nzolman, closes #122 * Fix `bcs` kwarg (#123) * Update conf.py * Update requirements.txt Add sphinx-book-theme * Update quickstart.rst * Update index.rst * Create basics.rst * Update index.rst * Complete refactoring of the docs. * Add in the glossary * Fix pinball BCs * Fix formatting * Fix warnings related to firedrake changes * [WIP] testing BDF/EXT3 solver * Schur complement preconditioning * Schur complement preconditioning * Add BDF to supported solvers * Common base class for firedrake transient solvers * Update pinball env * Update cavity and step * Minor actuator interface changes * Cleanup example script * Fix h5_file -> restart * Add benchmarking script to cavity * P1-P1 working, tuning constants * Set velocity order in flow config * Fix SUPG UFL form * Add GLS * Tested pinball * Tested on pinball * Fix checkpoint loading * Tested step w/ random forcing * Support stabilization in steady-state solver * P1-P1 working, tuning constants * Set velocity order in flow config * Fix SUPG UFL form * Add GLS * Tested pinball * Tested on pinball * Support stabilization in steady-state solver * P1-P1 working, tuning constants * Fix SUPG UFL form * Support stabilization in steady-state solver * Set BDF/GLS/P1P1 to be the defaults * Restore defaults to Taylor-Hood * ZNMF jet actuation for cylinder (#141) * Jet control for cylinder * Jet control for cylinder * Fix defaults for cylinder * Updated PD examples with rotary cylinder * Update hydrogym/firedrake/envs/cylinder/flow.py * Remove PD control example changes (unrelated) * Updates to Step environment (#149) * Helmholtz eigenvalue problem example * [WIP] testing direct stability on cylinder * Link to old code with working SLEPc call * Derive linear control term * Simple test problems for KS algorithm * Testing moving step forcing from solver to flow * Use simple discrete-time filter instead of ActuatorBase * Tested Step w/ forcing * Clean up old forcing code * update_actuation -> advance_time * Updated unsteady.py example script * black * Untrack stability analysis files * Configurable observation space for cylinder (#142) * Configurable observation space for cylinder * Configurable observation space for cylinder * Finish vel/pres probe implementation * Undo changes to examples/ * Add example script * Make probes available to all envs * linting * Remove coarse meshes (#150) * Support loading checkpoint from different function space (#151) * Remove IPCS solver (#152) * Remove IPCS solver * Fix import issues * Remove mixed= kwarg wherever possible * Update PD control example (#143) * Jet control for cylinder * Fix defaults for cylinder * Updated PD examples with rotary cylinder * Update hydrogym/firedrake/envs/cylinder/flow.py * Add bilinear filter for derivative (untested) * Support different filter types * Add and test filtered derivative estimate * Jet control for cylinder * Fix defaults for cylinder * Updated PD examples with rotary cylinder * Update hydrogym/firedrake/envs/cylinder/flow.py * Add bilinear filter for derivative (untested) * Support different filter types * Add and test filtered derivative estimate * Run pre-commit * Clean up phase sweep script * Begin showing the changes respected by Black. * Fix black error. --------- Co-authored-by: Ludger Paehler <[email protected]> --------- Co-authored-by: Jared Callaham <[email protected]> Co-authored-by: Jared Callaham <[email protected]> Co-authored-by: cl126162 <[email protected]>
ludgerpaehler
added a commit
that referenced
this pull request
Mar 15, 2024
* Begin updating tests to see where the API currently fails. * Add cautionary comment to dissuade users from using the pip package for now. * Update patching branch (#153) * Update docker_development.rst * Automatically launch the virtual environment, and install the editable version of HydroGym into it. * Remove the unused Icepack install, which messes with pip's ability to resolve package versions. * Add dedicated subpage to document the testing of HydroGym for package developers. * Adjust the list of authors to the more generic HydroGym Developers as authors * Bug fix, @nzolman, closes #122 * Fix `bcs` kwarg (#123) * Update conf.py * Update requirements.txt Add sphinx-book-theme * Update quickstart.rst * Update index.rst * Create basics.rst * Update index.rst * Complete refactoring of the docs. * Add in the glossary * Fix pinball BCs * Fix formatting * Fix warnings related to firedrake changes * [WIP] testing BDF/EXT3 solver * Schur complement preconditioning * Schur complement preconditioning * Add BDF to supported solvers * Common base class for firedrake transient solvers * Update pinball env * Update cavity and step * Minor actuator interface changes * Cleanup example script * Fix h5_file -> restart * Add benchmarking script to cavity * P1-P1 working, tuning constants * Set velocity order in flow config * Fix SUPG UFL form * Add GLS * Tested pinball * Tested on pinball * Fix checkpoint loading * Tested step w/ random forcing * Support stabilization in steady-state solver * P1-P1 working, tuning constants * Set velocity order in flow config * Fix SUPG UFL form * Add GLS * Tested pinball * Tested on pinball * Support stabilization in steady-state solver * P1-P1 working, tuning constants * Fix SUPG UFL form * Support stabilization in steady-state solver * Set BDF/GLS/P1P1 to be the defaults * Restore defaults to Taylor-Hood * ZNMF jet actuation for cylinder (#141) * Jet control for cylinder * Jet control for cylinder * Fix defaults for cylinder * Updated PD examples with rotary cylinder * Update hydrogym/firedrake/envs/cylinder/flow.py * Remove PD control example changes (unrelated) * Updates to Step environment (#149) * Helmholtz eigenvalue problem example * [WIP] testing direct stability on cylinder * Link to old code with working SLEPc call * Derive linear control term * Simple test problems for KS algorithm * Testing moving step forcing from solver to flow * Use simple discrete-time filter instead of ActuatorBase * Tested Step w/ forcing * Clean up old forcing code * update_actuation -> advance_time * Updated unsteady.py example script * black * Untrack stability analysis files * Configurable observation space for cylinder (#142) * Configurable observation space for cylinder * Configurable observation space for cylinder * Finish vel/pres probe implementation * Undo changes to examples/ * Add example script * Make probes available to all envs * linting * Remove coarse meshes (#150) * Support loading checkpoint from different function space (#151) * Remove IPCS solver (#152) * Remove IPCS solver * Fix import issues * Remove mixed= kwarg wherever possible * Update PD control example (#143) * Jet control for cylinder * Fix defaults for cylinder * Updated PD examples with rotary cylinder * Update hydrogym/firedrake/envs/cylinder/flow.py * Add bilinear filter for derivative (untested) * Support different filter types * Add and test filtered derivative estimate * Jet control for cylinder * Fix defaults for cylinder * Updated PD examples with rotary cylinder * Update hydrogym/firedrake/envs/cylinder/flow.py * Add bilinear filter for derivative (untested) * Support different filter types * Add and test filtered derivative estimate * Run pre-commit * Clean up phase sweep script * Begin showing the changes respected by Black. * Fix black error. --------- Co-authored-by: Ludger Paehler <[email protected]> --------- Co-authored-by: Jared Callaham <[email protected]> Co-authored-by: Jared Callaham <[email protected]> Co-authored-by: cl126162 <[email protected]> * Move PD controller out to the utilities. * Fix up cylinder tests. * Fix the pinball tests. * Move gradient tests out to dedicated test files. * Begin patching of the tests. * Clean up comments in file. * Render method fixes. * No need to add the velocity order. * Add Readme for the docs. * Fix the tests for the step environment. * Fix most tests, cavity fails on the nonlinear iteration. * Restructure the solver, added stabilization, but still getting solver errors. * Default stabilization change fixed it. * Together with @jcallaham changed the broken default stabilization. * Ruff fixes. * Ruff definitions patch * Fully connect the control test. * Fix last open test. * Reformat tests with black. --------- Co-authored-by: Jared Callaham <[email protected]> Co-authored-by: Jared Callaham <[email protected]> Co-authored-by: cl126162 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.