[20334] Configure the Log with a LogConfiguration #92

LuciaEchevarria99 · 2024-01-23T08:56:31Z

No description provided.

cpp_utils/src/cpp/logging/CustomStdLogConsumer.cpp

cpp_utils/include/cpp_utils/logging/CustomStdLogConsumer.hpp

cpp_utils/src/cpp/logging/CustomStdLogConsumer.cpp

codecov-commenter · 2024-01-31T10:14:22Z

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (20b5978) 69.82% compared to head (87908b7) 68.32%.

Files	Patch %	Lines
cpp_utils/src/cpp/logging/LogConfiguration.cpp	0.00%	25 Missing ⚠️
cpp_utils/src/cpp/logging/CustomStdLogConsumer.cpp	0.00%	10 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   69.82%   68.32%   -1.51%     
==========================================
  Files          60       61       +1     
  Lines        1455     1487      +32     
  Branches      388      401      +13     
==========================================
  Hits         1016     1016              
- Misses        213      245      +32     
  Partials      226      226

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Lucia Echevarria <[email protected]>

…s for consistency Signed-off-by: Lucia Echevarria <[email protected]>

Signed-off-by: Lucia Echevarria <[email protected]>

cpp_utils/include/cpp_utils/logging/LogConfiguration.hpp

cpp_utils/src/cpp/logging/LogConfiguration.cpp

…pply suggested changes Signed-off-by: Lucia Echevarria <[email protected]>

Signed-off-by: Lucia Echevarria <[email protected]>

cpp_utils/include/cpp_utils/logging/LogConfiguration.hpp

cpp_utils/src/cpp/logging/LogConfiguration.cpp

cpp_utils/include/cpp_utils/logging/LogConfiguration.hpp

cpp_utils/src/cpp/logging/LogConfiguration.cpp

…some other minor changes Signed-off-by: Lucia Echevarria <[email protected]>

Signed-off-by: Lucia Echevarria <[email protected]>

… or commandline Signed-off-by: Lucia Echevarria <[email protected]>

cpp_utils/src/cpp/logging/LogConfiguration.cpp

cpp_utils/include/cpp_utils/logging/CustomStdLogConsumer.hpp

Signed-off-by: Lucia Echevarria <[email protected]>

Tempate

LGTM

…pointer and convert LogConfiguration is_valid method to virtual Signed-off-by: Lucia Echevarria <[email protected]>

Tempate

LGTM

LuciaEchevarria99 temporarily deployed to codecov January 23, 2024 08:56 — with GitHub Actions Inactive

LuciaEchevarria99 force-pushed the feature/fault_reporting branch from 6b931fe to 6dddd8f Compare January 23, 2024 08:59

LuciaEchevarria99 temporarily deployed to codecov January 23, 2024 08:59 — with GitHub Actions Inactive

Tempate suggested changes Jan 30, 2024

View reviewed changes

LuciaEchevarria99 had a problem deploying to codecov January 31, 2024 09:48 — with GitHub Actions Failure

LuciaEchevarria99 temporarily deployed to codecov January 31, 2024 09:51 — with GitHub Actions Inactive

LuciaEchevarria99 temporarily deployed to codecov February 1, 2024 10:06 — with GitHub Actions Inactive

LuciaEchevarria99 added 5 commits February 1, 2024 12:06

Changes on CustomLogConsumer to accept LogFilter maps

00bda84

Signed-off-by: Lucia Echevarria <[email protected]>

Rename variables log_filter_map_ and filter_map_

c5a151a

Signed-off-by: Lucia Echevarria <[email protected]>

Change if statements to booleans in accept_entry_ and unify parameter…

f3dc2e6

…s for consistency Signed-off-by: Lucia Echevarria <[email protected]>

Correct uncrustify

dc4e84b

Signed-off-by: Lucia Echevarria <[email protected]>

Include LogConfiguration struct in dev-utils

aaa7977

Signed-off-by: Lucia Echevarria <[email protected]>

LuciaEchevarria99 force-pushed the feature/fault_reporting branch from eb67530 to aaa7977 Compare February 1, 2024 11:06

LuciaEchevarria99 temporarily deployed to codecov February 1, 2024 11:07 — with GitHub Actions Inactive

This was referenced Feb 1, 2024

[20334] Configure the Log through YAML eProsima/DDS-Pipe#86

Merged

[20334] Configure the Log through YAML eProsima/DDS-Record-Replay#115

Merged

Tempate suggested changes Feb 2, 2024

View reviewed changes

cpp_utils/include/cpp_utils/logging/LogConfiguration.hpp Outdated Show resolved Hide resolved

cpp_utils/src/cpp/logging/LogConfiguration.cpp Outdated Show resolved Hide resolved

cpp_utils/src/cpp/logging/LogConfiguration.cpp Outdated Show resolved Hide resolved

LuciaEchevarria99 changed the title ~~Changes in CustomStdLogConsumer to admit LogFilter map~~ [20334] Changes in CustomStdLogConsumer to admit LogFilter map Feb 5, 2024

LuciaEchevarria99 changed the title ~~[20334] Changes in CustomStdLogConsumer to admit LogFilter map~~ [20334] Configure the Log with a LogConfiguration Feb 5, 2024

Change LogFilter to std::map<VerbosityKind, Fuzzy<std::string>> and a…

ec3e17d

…pply suggested changes Signed-off-by: Lucia Echevarria <[email protected]>

LuciaEchevarria99 temporarily deployed to codecov February 7, 2024 14:48 — with GitHub Actions Inactive

Add set_if_unset methods

28f4ca5

Signed-off-by: Lucia Echevarria <[email protected]>

LuciaEchevarria99 had a problem deploying to codecov February 8, 2024 07:47 — with GitHub Actions Failure

Tempate suggested changes Feb 8, 2024

View reviewed changes

cpp_utils/include/cpp_utils/logging/LogConfiguration.hpp Outdated Show resolved Hide resolved

cpp_utils/src/cpp/logging/LogConfiguration.cpp Outdated Show resolved Hide resolved

Tempate suggested changes Feb 9, 2024

View reviewed changes

cpp_utils/include/cpp_utils/logging/LogConfiguration.hpp Outdated Show resolved Hide resolved

cpp_utils/include/cpp_utils/logging/LogConfiguration.hpp Outdated Show resolved Hide resolved

cpp_utils/src/cpp/logging/LogConfiguration.cpp Outdated Show resolved Hide resolved

Set preference of log configuration via terminal over yaml and apply …

74f15c5

…some other minor changes Signed-off-by: Lucia Echevarria <[email protected]>

LuciaEchevarria99 had a problem deploying to codecov February 12, 2024 17:16 — with GitHub Actions Failure

Change ostream function

2f714c3

Signed-off-by: Lucia Echevarria <[email protected]>

LuciaEchevarria99 temporarily deployed to codecov February 13, 2024 07:21 — with GitHub Actions Inactive

Correct uncrustify

cacb83c

Signed-off-by: Lucia Echevarria <[email protected]>

LuciaEchevarria99 temporarily deployed to codecov February 13, 2024 07:41 — with GitHub Actions Inactive

Add includes for Windows compilation

5f83e14

Signed-off-by: Lucia Echevarria <[email protected]>

LuciaEchevarria99 temporarily deployed to codecov February 13, 2024 08:30 — with GitHub Actions Inactive

LuciaEchevarria99 temporarily deployed to codecov February 13, 2024 08:45 — with GitHub Actions Inactive

Change set method to fix Log Configuration when not parsing from yaml…

3ffd5fa

… or commandline Signed-off-by: Lucia Echevarria <[email protected]>

LuciaEchevarria99 temporarily deployed to codecov February 13, 2024 15:29 — with GitHub Actions Inactive

Tempate suggested changes Feb 14, 2024

View reviewed changes

cpp_utils/src/cpp/logging/LogConfiguration.cpp Outdated Show resolved Hide resolved

cpp_utils/include/cpp_utils/logging/CustomStdLogConsumer.hpp Outdated Show resolved Hide resolved

cpp_utils/include/cpp_utils/logging/CustomStdLogConsumer.hpp Outdated Show resolved Hide resolved

Change some comments

87908b7

Signed-off-by: Lucia Echevarria <[email protected]>

LuciaEchevarria99 temporarily deployed to codecov February 14, 2024 08:48 — with GitHub Actions Inactive

Tempate previously approved these changes Feb 14, 2024

View reviewed changes

LuciaEchevarria99 temporarily deployed to codecov February 14, 2024 11:06 — with GitHub Actions Inactive

This was referenced Feb 15, 2024

[19983] Publish Fast-DDS's Logs eProsima/DDS-Record-Replay#128

Merged

[19983] Publish Fast-DDS's Logs eProsima/DDS-Pipe#92

Merged

Refactor CustomStdLogConsumer constructor argument from reference to …

64aef29

…pointer and convert LogConfiguration is_valid method to virtual Signed-off-by: Lucia Echevarria <[email protected]>

LuciaEchevarria99 dismissed Tempate’s stale review via 64aef29 February 16, 2024 10:33

LuciaEchevarria99 temporarily deployed to codecov February 16, 2024 10:33 — with GitHub Actions Inactive

Tempate approved these changes Feb 19, 2024

View reviewed changes

LuciaEchevarria99 temporarily deployed to codecov February 19, 2024 07:02 — with GitHub Actions Inactive

Tempate mentioned this pull request Feb 23, 2024

[19983] Publish Fast-DDS's Logs eProsima/DDS-Router#436

Merged

LuciaEchevarria99 mentioned this pull request Mar 1, 2024

[20334] Configure the Log through YAML eProsima/Fast-DDS-spy#74

Merged

Tempate mentioned this pull request Mar 1, 2024

[19983] Publish Fast-DDS's Logs eProsima/Fast-DDS-spy#75

Merged

rsanchez15 merged commit 63b19c3 into main Mar 5, 2024
15 of 16 checks passed

rsanchez15 deleted the feature/fault_reporting branch March 5, 2024 08:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[20334] Configure the Log with a LogConfiguration #92

[20334] Configure the Log with a LogConfiguration #92

LuciaEchevarria99 commented Jan 23, 2024

codecov-commenter commented Jan 31, 2024 •

edited

Loading

Tempate left a comment

Tempate left a comment

[20334] Configure the Log with a LogConfiguration #92

[20334] Configure the Log with a LogConfiguration #92

Conversation

LuciaEchevarria99 commented Jan 23, 2024

codecov-commenter commented Jan 31, 2024 • edited Loading

Codecov Report

Tempate left a comment

Choose a reason for hiding this comment

Tempate left a comment

Choose a reason for hiding this comment

codecov-commenter commented Jan 31, 2024 •

edited

Loading