[19983] Split the CustomStdLogConsumer into a BaseLogConsumer and a StdLogConsumer #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
==========================================
- Coverage 68.32% 67.98% -0.35%
==========================================
Files 61 62 +1
Lines 1487 1493 +6
Branches 401 401
==========================================
- Hits 1016 1015 -1
- Misses 245 251 +6
- Partials 226 227 +1 ☔ View full report in Codecov by Sentry. |
Tempate
changed the title
Tempate
force-pushed
the
feature/publish_logs
branch
from
6574475 to
440421f
Compare
Signed-off-by: tempate <[email protected]>
…sumer Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Tempate
dismissed
LuciaEchevarria99’s stale review
The merge-base changed after approval.
Tempate
force-pushed
the
feature/publish_logs
branch
from
5e05920 to
d767caf
Compare
This was referenced Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this version, the
CustomStdLogConsumerhas been split into two: aBaseLogConsumerthat filters the logs based on their kind and content and aStdLogConsumerthat prints the logs through std.