Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update color scheme for edx App #6

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Conversation

omerhabib26
Copy link

Description:

  • Update color scheme according to new edx designs

Copy link

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things to Look Into

Light Mode:

  • "Switch to Limited Profile" button on Edit Profile
  • Course Progress Bar on Primary View and Home
  • Download Videos Icon Color
  • Course Calendar Dialog Buttons
  • Check Mark Color on Value Prop

Dark Mode:

  • "Switch to Limited Profile" Button on Edit Profile
  • Course Progress Bar on Primary View and Home
  • Download Videos Icon Color
  • Course Calendar Dialog Buttons
  • "You Must Be Over 13 ..." Snackbar Text Color
  • Progress Bar on Component Screen
  • Text color on the Primary Course Card background (dark_surface) and other areas where dark_surface is used as the background

Please remove the fitsSystemWindows attribute, as it conflicts with the Next and Previous buttons on the course component.

- refactor app design to efficiently handle customAppColor variables

fix: LEARNER-10043
Copy link

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes. 🏎️

@HamzaIsrar12 HamzaIsrar12 merged commit 44e39d8 into 2U/develop Jul 17, 2024
4 checks passed
@HamzaIsrar12 HamzaIsrar12 deleted the 2U/edx_theme branch July 17, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants