Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Minor UI & Feature Set Changes #7

Merged
merged 11 commits into from
Jul 18, 2024
Merged

fix: Minor UI & Feature Set Changes #7

merged 11 commits into from
Jul 18, 2024

Conversation

HamzaIsrar12
Copy link

@HamzaIsrar12 HamzaIsrar12 commented Jul 13, 2024 •
edited
Loading

The following views or features are hidden as part of this PR:

  • Device-Specific Arithmetic Exception on Pixel
  • Fixes the View All Course Count
  • Checkbox State on SignUp Screen
  • Remove Calendar Sync from Settings Screen
  • Remove Search Icon from All Courses (Grid View)
  • Disabled the New Notification API
  • Fixed Notification Permission Dialog on Course Home
  • Text Field Keyboard Padding in Discovery Webview
  • Contact Support Email Subject on Settings Screen
  • Center Align Edit Profile Fields
  • Fixed the User Agent Issue on Component Webviews

farhan-arshad-dev
farhan-arshad-dev requested changes Jul 16, 2024
View reviewed changes
core/src/main/java/org/openedx/core/domain/model/Progress.kt Show resolved Hide resolved
auth/src/main/java/org/openedx/auth/data/model/RegistrationFields.kt Show resolved Hide resolved
auth/src/main/java/org/openedx/auth/presentation/ui/CheckboxField.kt Show resolved Hide resolved
core/src/main/java/org/openedx/core/domain/model/RegistrationField.kt Show resolved Hide resolved
dashboard/src/main/java/org/openedx/courses/presentation/AllEnrolledCoursesView.kt Show resolved Hide resolved
discovery/src/main/java/org/openedx/discovery/presentation/WebViewDiscoveryFragment.kt Outdated Show resolved Hide resolved
course/src/main/java/org/openedx/course/presentation/unit/html/HtmlUnitViewModel.kt Outdated Show resolved Hide resolved
course/src/main/java/org/openedx/course/presentation/unit/html/HtmlUnitViewModel.kt Outdated Show resolved Hide resolved
course/src/main/java/org/openedx/course/presentation/unit/html/HtmlUnitViewModel.kt Outdated Show resolved Hide resolved
Base automatically changed from 2U/edx_theme to 2U/develop July 17, 2024 10:37
@HamzaIsrar12 HamzaIsrar12 merged commit b206ef2 into 2U/develop Jul 18, 2024
4 checks passed
@HamzaIsrar12 HamzaIsrar12 deleted the 2U/ui_fixes branch July 18, 2024 07:17
@HamzaIsrar12 HamzaIsrar12 self-assigned this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farhan-arshad-dev farhan-arshad-dev farhan-arshad-dev approved these changes

@k1rill k1rill k1rill approved these changes

@omerhabib26 omerhabib26 Awaiting requested review from omerhabib26

@dixidroid dixidroid Awaiting requested review from dixidroid

Assignees

@HamzaIsrar12 HamzaIsrar12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HamzaIsrar12 @k1rill @farhan-arshad-dev