Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serverless shared attributes #3109

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Nov 7, 2024

Relates to elastic/docs-content#182

This PR moves the declarations from https://github.com/elastic/docs-content/blob/7602ddbdb3de8fe99b0850423c308f85e2952d6d/serverless/index.asciidoc?plain=1#L13 to the list of shared attributes so that they can be used in all books.

@lcawl lcawl requested a review from a team as a code owner November 7, 2024 19:55
Copy link

github-actions bot commented Nov 7, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

colleenmcginnis
colleenmcginnis previously approved these changes Nov 7, 2024
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This was in my post-migration list along with #3107 and #3108. 🙂 Feel free to delete from the file in /docs-content, too!

@lcawl lcawl enabled auto-merge (squash) November 7, 2024 20:15
colleenmcginnis
colleenmcginnis previously approved these changes Nov 7, 2024
@lcawl lcawl enabled auto-merge (squash) November 7, 2024 23:48
@lcawl lcawl merged commit 6aef2b9 into elastic:master Nov 8, 2024
3 checks passed
@lcawl lcawl deleted the serverless-vars branch November 8, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants