Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profiling: add edge case resolution in known issues #3235

Merged
merged 3 commits into from
Sep 21, 2023
Merged

profiling: add edge case resolution in known issues #3235

merged 3 commits into from
Sep 21, 2023

Conversation

inge4pres
Copy link
Contributor

Reason for this PR

Address the non-documented case of 8.9.0 setup (faulty) trying to upgrade to a more recent version.

@inge4pres inge4pres added backport v8.10.0 backport-8.10 Automated backport with mergify labels Sep 15, 2023
@inge4pres inge4pres self-assigned this Sep 15, 2023
@github-actions
Copy link
Contributor

A documentation preview will be available soon:

@inge4pres inge4pres marked this pull request as ready for review September 19, 2023 15:33
@inge4pres inge4pres requested a review from a team as a code owner September 19, 2023 15:33
mdbirnstiehl
mdbirnstiehl approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some wording suggestions, but otherwise LGTM.

docs/en/observability/profiling-get-started.asciidoc Outdated Show resolved Hide resolved
@inge4pres @mdbirnstiehl
improve wording
8cb207d 
Co-authored-by: Mike Birnstiehl <[email protected]>
@inge4pres
Copy link
Contributor Author

Some wording suggestions, but otherwise LGTM.

Thanks 🙏🏼
Do we need to worry about the CI failing job?

@inge4pres inge4pres removed the request for review from lucabelluccini September 20, 2023 09:35
@inge4pres
Copy link
Contributor Author

/test

@inge4pres @mdbirnstiehl
fix link
f194331 
Co-authored-by: Mike Birnstiehl <[email protected]>
@inge4pres inge4pres merged commit e72a87a into main Sep 21, 2023
1 check passed
@inge4pres inge4pres deleted the profiling/upgrade-error-workaround branch September 21, 2023 09:20
mergify bot pushed a commit that referenced this pull request Sep 21, 2023
@inge4pres @mergify
profiling: add edge case resolution in known issues (#3235)
4ca07bc 
Signed-off-by: inge4pres <[email protected]>
Co-authored-by: Mike Birnstiehl <[email protected]>
(cherry picked from commit e72a87a)
@mergify mergify bot mentioned this pull request Sep 21, 2023
Merged
inge4pres added a commit that referenced this pull request Sep 21, 2023
@mergify @inge4pres
profiling: add edge case resolution in known issues (#3235) (#3239)
4178da2 
Signed-off-by: inge4pres <[email protected]>
Co-authored-by: Mike Birnstiehl <[email protected]>
(cherry picked from commit e72a87a)

Co-authored-by: Francesco Gualazzi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdbirnstiehl mdbirnstiehl mdbirnstiehl approved these changes

@iogbole iogbole Awaiting requested review from iogbole

Assignees

@inge4pres inge4pres

Labels
backport backport-8.10 Automated backport with mergify v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inge4pres @mdbirnstiehl