Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use <Link/> in lineralite list view; fix priority/status assignment ui #2239

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alsuren
Copy link

@alsuren alsuren commented Jan 22, 2025

this is related to #2238 in that it allows you to reproduce the issue a bit better

Probably easier to review with whitespace turned off - https://github.com/electric-sql/electric/pull/2239/files?w=1

steps to test:

  • Check that "open in a new tab" and "open in an incognito tab" work
    • open http://localhost:5173/
    • right click on an issue title
      • on main, this is not a link, so nothing useful is in the context menu
      • on this branch, this is a <Link > (an <a> with a click handler that does the preventDefault() + redirect dance), so you get the following context menu:
        • Screenshot 2025-01-22 at 12 20 38
        • I have no idea why right-clicking on the text causes the title + time + opener (everything in the to be selected. If you are fine with this, please check this box)
        • Note that "open in incognito window" will not work until fix linearlite loading if issue url is opened directly with no synced issue database #2238 is merged
        • check that ⌘+click works too, and check that clicking around normally works
        • check that the click target for the is the full height of the row (not just the height of the text)
  • Check that PriorityMenu and StatusMenu now work
    • click on PriorityMenu
      • on main this click is sometimes swallowed by the reroute to the item page, depending on whether you tap super-quickly on your touchpad or click a bit harder. I thought about trying to work out where to put the stopPropagation() or whatever to protect these menu clicks, but in the end I decided to move them outside the <Link>.
      • on this branch it should look like this always:
        Screenshot 2025-01-22 at 12 38 35
      • updates should be immediately reflected in the UI
        • sometimes the thing seems to get wedged and the ui updates don't happen, but it fixes itself on refresh and ui updates happen instantly again (I think this is related the issue that I was trying to debug when I started this whole journey. Something to do with stack overflow in wasm somewhere? I will make an issue for this when I have a reliable reproduction and then I will check this box).
        • I seem to always have the broken cloud icon on rows that I have changed. I think this is either normal or unrelated though? Please check this box if this is fine, otherwise leave a comment and I will look into it further.
    • same for StatusMenu

@alsuren alsuren force-pushed the linearlite-list-fixes branch from 5a6ca11 to ff3e075 Compare January 22, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant