Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use <Link/> in lineralite list view; fix priority/status assignment ui #2239

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+22 −19
Open

use <Link/> in lineralite list view; fix priority/status assignment ui #2239

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf54d7d
use <Link/> in lineralite list view; fix priority/status assignment ui
alsuren Jan 22, 2025
ff3e075
make link click target full height
alsuren Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 22 additions & 19 deletions examples/linearlite/src/pages/List/IssueRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import PriorityIcon from '../../components/PriorityIcon'
import StatusIcon from '../../components/StatusIcon'
import Avatar from '../../components/Avatar'
import { memo } from 'react'
import { useNavigate } from 'react-router-dom'
import { Link } from 'react-router-dom'
import { formatDate } from '../../utils/date'
import { Issue } from '../../types/types'

Expand All @@ -19,7 +19,6 @@ interface Props {

function IssueRow({ issue, style }: Props) {
const pg = usePGlite()
const navigate = useNavigate()

const handleChangeStatus = (status: string) => {
pg.sql`
Expand Down Expand Up @@ -53,7 +52,6 @@ function IssueRow({ issue, style }: Props) {
key={issue.id}
className="flex items-center flex-grow w-full min-w-0 pl-2 pr-8 text-sm border-b border-gray-100 hover:bg-gray-100 shrink-0"
id={issue.id}
onClick={() => navigate(`/issue/${issue.id}`)}
style={style}
>
<div className="flex-shrink-0 ml-4">
Expand All @@ -70,22 +68,27 @@ function IssueRow({ issue, style }: Props) {
onSelect={handleChangeStatus}
/>
</div>
<div className="flex-wrap flex-shrink ml-3 overflow-hidden font-medium line-clamp-1 overflow-ellipsis">
{issue.title.slice(0, 3000) || ``}
</div>
<div className="flex-shrink-0 hidden w-15 ml-auto font-normal text-gray-500 sm:block whitespace-nowrap">
{formatDate(issue.created)}
</div>
<div className="flex-shrink-0 hidden ml-4 font-normal text-gray-500 sm:block w-15 md:block">
<Avatar name={issue.username} />
</div>
<div className="flex-shrink-0 hidden ml-4 font-normal text-gray-500 sm:block w-15 md:block">
{issue.synced ? (
<SyncedIcon className="text-green-500 w-4 h-4" />
) : (
<UnsyncedIcon className="text-orange-500 w-4 h-4" />
)}
</div>
<Link
to={`/issue/${issue.id}`}
className="flex items-center flex-grow min-w-0 h-full"
>
<div className="flex-wrap flex-shrink ml-3 overflow-hidden font-medium line-clamp-1 overflow-ellipsis">
{issue.title.slice(0, 3000) || ``}
</div>
<div className="flex-shrink-0 hidden w-15 ml-auto font-normal text-gray-500 sm:block whitespace-nowrap">
{formatDate(issue.created)}
</div>
<div className="flex-shrink-0 hidden ml-4 font-normal text-gray-500 sm:block w-15 md:block">
<Avatar name={issue.username} />
</div>
<div className="flex-shrink-0 hidden ml-4 font-normal text-gray-500 sm:block w-15 md:block">
{issue.synced ? (
<SyncedIcon className="text-green-500 w-4 h-4" />
) : (
<UnsyncedIcon className="text-orange-500 w-4 h-4" />
)}
</div>
</Link>
</div>
)
}
Expand Down