Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump RTE version to 2.18.0 #7711

Merged
merged 9 commits into from
Nov 21, 2023
Merged

Bump RTE version to 2.18.0 #7711

merged 9 commits into from
Nov 21, 2023

Conversation

nimau
Copy link
Contributor

@nimau nimau commented Nov 15, 2023 •
edited
Loading

This PR updates the version of RTE used in Element iOS.
This fixes:

Changes:

  • Deployment target is now 15.0
  • Updated WysiwygComposer to 2.18.0
  • Updated DTCoreText to 1.6.26

@nimau nimau added the Trigger-PR-Build Label to trigger builds for PRs label Nov 15, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2023 •
edited
Loading

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/qac2qv

@codecov Codecov
Copy link

codecov bot commented Nov 15, 2023 •
edited
Loading

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (5a0a0f9) 6.22% compared to head (a259e91) 12.38%.

Files Patch % Lines
Riot/Modules/Room/RoomViewController.swift 0.00% 18 Missing ⚠️
.../WYSIWYGInputToolbar/WysiwygInputToolbarView.swift 0.00% 17 Missing ⚠️
...tSwiftUI/Modules/Room/Composer/View/Composer.swift 81.66% 10 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #7711      +/-   ##
===========================================
+ Coverage     6.22%   12.38%   +6.16%     
===========================================
  Files         1648     1650       +2     
  Lines       163846   163929      +83     
  Branches     66296    66414     +118     
===========================================
+ Hits         10200    20306   +10106     
+ Misses      153203   142955   -10248     
- Partials       443      668     +225
Flag Coverage Δ
uitests 55.02% <81.96%> (?)
unittests 6.22% <3.03%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nimau nimau removed the Trigger-PR-Build Label to trigger builds for PRs label Nov 15, 2023
@alfogrillo alfogrillo added Trigger-PR-Build Label to trigger builds for PRs and removed Trigger-PR-Build Label to trigger builds for PRs labels Nov 16, 2023
@nimau nimau added the Trigger-PR-Build Label to trigger builds for PRs label Nov 16, 2023
@nimau nimau removed the Trigger-PR-Build Label to trigger builds for PRs label Nov 17, 2023
@nimau nimau added Trigger-PR-Build Label to trigger builds for PRs and removed Trigger-PR-Build Label to trigger builds for PRs labels Nov 17, 2023
alfogrillo
alfogrillo approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@alfogrillo alfogrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

RiotSwiftUI/Modules/Room/Composer/View/Composer.swift Outdated Show resolved Hide resolved
@Velin92 Velin92 mentioned this pull request Nov 20, 2023
Closed
@Velin92
Copy link
Member

Velin92 commented Nov 20, 2023

Let's bump this up to 2.18.0 so that we can also fix the nasty #7489 bug

Velin92
Velin92 reviewed Nov 20, 2023
View reviewed changes
project.yml Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@nimau nimau added the Trigger-PR-Build Label to trigger builds for PRs label Nov 20, 2023
@nimau nimau changed the title Bump RTE version to 2.15.0 Bump RTE version to 2.18.0 Nov 20, 2023
@nimau nimau added Trigger-PR-Build Label to trigger builds for PRs and removed Trigger-PR-Build Label to trigger builds for PRs labels Nov 20, 2023
@nimau nimau merged commit d088e98 into develop Nov 21, 2023
10 of 11 checks passed
@nimau nimau deleted the nicolas/update-RTE-2.15 branch November 21, 2023 11:36
@NicolasBuquet NicolasBuquet mentioned this pull request Dec 11, 2023
Closed
@giomfo giomfo mentioned this pull request Jan 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Velin92 Velin92 Velin92 left review comments

@alfogrillo alfogrillo alfogrillo approved these changes

@langleyd langleyd Awaiting requested review from langleyd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nimau @Velin92 @alfogrillo