Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match against ES5/ES6 JavaScript files #153

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ilanbiala
Copy link
Contributor

Fixes #144.

@ilanbiala ilanbiala mentioned this pull request Mar 28, 2015
'test/fixtures/test.es'
];

text.expect(1);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that text doesn't exist. Is a typo, maybe it should be test instead of.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MathRobin sorry your response got cut off, instead of what? If you look at the files changed tab, GitHub says it was added I believe.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my bad english.

I would like to say that you did a mistake. On line 138, you wrote the word "text" instead of the word "test". That's why the tests don't passed.

@thalesfsp thalesfsp mentioned this pull request May 16, 2016
kyungilpark added a commit to kyungilpark/plato that referenced this pull request Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plato.inspect does not recognize files with '.es' extension.
2 participants