Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-mixpanel-native: enable minimal_cohort_members_properties functionality #2246

Merged
merged 1 commit into from
Jan 6, 2025
Merged

source-mixpanel-native: enable minimal_cohort_members_properties functionality #2246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions source-mixpanel-native/source_mixpanel_native/streams/cohort_members.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ def __init__(

# Since we know that each result received from the Mixpanel API will be a consistent, pretty small size when the
# minimal_cohort_members_properties flag is set, we can use a very large page size to page through results faster.
# if minimal_cohort_members_properties:
# page_size = 1_000_000
if minimal_cohort_members_properties:
page_size = 1_000_000

super().__init__(
page_size=page_size,
Expand All @@ -58,8 +58,8 @@ def request_params(
params = super().request_params(stream_state, stream_slice, next_page_token)
params = {**params, "page_size": self.page_size}

# if self.minimal_cohort_members_properties:
# params['output_properties'] = '"$last_seen"'
if self.minimal_cohort_members_properties:
params['output_properties'] = '"$last_seen"'

if next_page_token:
params.update(next_page_token)
Expand Down
Loading