Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add dnd-character exercise #86

Merged
merged 1 commit into from
Nov 27, 2024
Merged

feat: add dnd-character exercise #86

merged 1 commit into from
Nov 27, 2024

Conversation

vaeng
Copy link
Contributor

@vaeng vaeng commented Nov 27, 2024

No description provided.

@vaeng vaeng requested a review from ErikSchierboom November 27, 2024 10:53
vaeng
vaeng commented Nov 27, 2024
View reviewed changes
Copy link
Contributor Author

@vaeng vaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added three tests to check if the |0.1 functions are really functions, that return different values for each call and not only constants.
I often wondered if we should add this to the problem-specs.

ErikSchierboom
ErikSchierboom approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@vaeng vaeng merged commit 9f579df into main Nov 27, 2024
4 checks passed
@vaeng vaeng deleted the add-dnd-exercise branch November 27, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vaeng @ErikSchierboom