Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eas-cli] Use credentials types from eas-build-job where possible #2191

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Use credentials types from eas-build-job where possible

d8e8060
Select commit
Loading
Failed to load commit list.
Open

[eas-cli] Use credentials types from eas-build-job where possible #2191

Use credentials types from eas-build-job where possible
d8e8060
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 19, 2024 in 1s

54.10% (+0.01%) compared to 8ea0579

View this Pull Request on Codecov

54.10% (+0.01%) compared to 8ea0579

Details

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (8ea0579) 54.10% compared to head (d8e8060) 54.10%.

Files Patch % Lines
packages/eas-cli/src/build/ios/prepareJob.ts 20.00% 4 Missing ⚠️
...s/eas-cli/src/credentials/credentialsJson/utils.ts 0.00% 1 Missing ⚠️
...-cli/src/credentials/ios/IosCredentialsProvider.ts 66.67% 1 Missing ⚠️
...ctions/SetUpBuildCredentialsFromCredentialsJson.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2191      +/-   ##
==========================================
+ Coverage   54.10%   54.10%   +0.01%     
==========================================
  Files         516      516              
  Lines       18795    18793       -2     
  Branches     3769     3769              
==========================================
  Hits        10167    10167              
+ Misses       8607     8605       -2     
  Partials       21       21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov