Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[eas-cli] [ENG-9957] Don't overwrite distribution for simulator builds" #2207

Conversation

szdziedzic
Copy link
Member

Reverts #2073

Copy link

linear bot commented Jan 31, 2024

Copy link

✅ Thank you for adding the changelog entry!

Copy link

Size Change: +1.07 kB (0%)

Total Size: 51.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.5 MB +1.07 kB (0%)

compressed-size-action

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (315b5b2) 54.16% compared to head (c527fe1) 54.16%.

Files Patch % Lines
packages/eas-cli/src/build/metadata.ts 0.00% 3 Missing ⚠️
packages/eas-cli/src/commands/build/run.ts 50.00% 1 Missing ⚠️
packages/eas-cli/src/run/utils.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2207      +/-   ##
==========================================
+ Coverage   54.16%   54.16%   +0.01%     
==========================================
  Files         516      516              
  Lines       18814    18808       -6     
  Branches     3969     3968       -1     
==========================================
- Hits        10188    10186       -2     
+ Misses       7934     7931       -3     
+ Partials      692      691       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic szdziedzic merged commit a6e281b into main Jan 31, 2024
9 checks passed
@szdziedzic szdziedzic deleted the revert-2073-@radoslawkrzemien/ENG-9957-dont-overwrite-distribution-for-simulator-builds branch January 31, 2024 20:06
radoslawkrzemien added a commit that referenced this pull request Feb 1, 2024
radoslawkrzemien added a commit that referenced this pull request Feb 5, 2024
* Revert "Revert "[eas-cli] [ENG-9957] Don't overwrite distribution for simulator build…" (#2207)"

This reverts commit a6e281b

* [eas-cli] Generate schema

Re-generated gql schema

See: https://linear.app/expo/issue/ENG-11247/fix-console-output-when-creating-asc-key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants