chore: Split out data attributes to separate files #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
compressed-size: runtime library Size change: +0.01 kB
View unchanged
|
necolas
pushed a commit
that referenced
this pull request
Apr 4, 2024
Allow arbitrary data-* props at runtime. On web, the check is only performed during development. To workaround Flow's lack of support for typing arbitary data-* props, a separate type is created just for data-* props which can be used to maintain an app's list of supported data-* props. Ref #71 Close #75
necolas
force-pushed
the
chore/data-attrs
branch
from
9a15d99 to
43b8181
Compare
|
I reworked this PR to:
Please take a look and let me know if it still looks OK to you. Thanks! |
|
I'll revisit this to use the approach we took for |
necolas
pushed a commit
that referenced
this pull request
Apr 4, 2024
Allow arbitrary data-* props at runtime. On web, the check is only performed during development. To workaround Flow's lack of support for typing arbitary data-* props, a separate type is created just for data-* props which can be used to maintain an app's list of supported data-* props. Ref #71 Close #75
necolas
force-pushed
the
chore/data-attrs
branch
from
43b8181 to
7b5732a
Compare
Allow arbitrary data-* props at runtime. On web, the check is only performed during development. To workaround Flow's lack of support for typing arbitary data-* props, a separate type is created just for data-* props which can be used to maintain an app's list of supported data-* props. Ref #71 Close #75
necolas
force-pushed
the
chore/data-attrs
branch
from
7b5732a to
b32baeb
Compare
nmn
commented
Apr 6, 2024
| // This type allows Meta to internally override it with an | ||
| // internationalization type which is a string at runtime… | ||
| // but Flow doesn't know that. | ||
| declare type Stringish = string; |
There was a problem hiding this comment.
This will be a problem for the generated TS types. We should use explicit imports and avoid usage of any "globals".
There was a problem hiding this comment.
Yeah we can fix that pre-existing issue later after fixing internal and syncing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop-gap solution for #71
This is a simple refactor that splits out all definitions of
data-*attributes to separate files. This makes it easier to maintain a separate list of supported attributes internally without the need for patch files etc.