Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler] Update readme with link to Rules of React docs #30095

Closed
wants to merge 12 commits into from

Conversation

poteto
Copy link
Member

@poteto poteto commented Jun 25, 2024

Stack from ghstack (oldest at bottom):

Update readme with a useful link but also test if circleci filtering is
working

[ghstack-poisoned]
Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 3:20am

poteto added a commit that referenced this pull request Jun 25, 2024
Update readme with a useful link but also test if circleci filtering is
working

ghstack-source-id: 5301118a46f01e7cd068aff2bdfef0902420b0be
Pull Request resolved: #30095
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 25, 2024
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jun 25, 2024
Update readme with a useful link but also test if circleci filtering is
working

ghstack-source-id: 30be28bdb20b1c0e7fdd6ce8f9cdf217978767a8
Pull Request resolved: #30095
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jun 25, 2024
Update readme with a useful link but also test if circleci filtering is
working

ghstack-source-id: 83ce5b32d0f4335536c6f41605974f9025ce0409
Pull Request resolved: #30095
@poteto poteto mentioned this pull request Jun 25, 2024
[ghstack-poisoned]
[ghstack-poisoned]
@react-sizebot
Copy link

react-sizebot commented Jun 25, 2024

Comparing: 708d8f8...8297749

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.93 kB 497.93 kB = 89.26 kB 89.26 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.75 kB 502.75 kB = 89.96 kB 89.96 kB
facebook-www/ReactDOM-prod.classic.js = 597.10 kB 597.10 kB = 105.31 kB 105.31 kB
facebook-www/ReactDOM-prod.modern.js = 571.44 kB 571.44 kB = 101.24 kB 101.24 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Generated by 🚫 dangerJS against 8297749

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@poteto poteto closed this Jul 26, 2024
@poteto poteto deleted the gh/poteto/30/head branch July 26, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants