Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React readme #30096

Closed
wants to merge 10 commits into from
Closed

Update React readme #30096

wants to merge 10 commits into from

Conversation

poteto
Copy link
Member

@poteto poteto commented Jun 25, 2024

[ghstack-poisoned]
Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 3:20am

poteto added a commit that referenced this pull request Jun 25, 2024
ghstack-source-id: 38a08356d737ef77b2f74285686a4119ed490a66
Pull Request resolved: #30096
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 25, 2024
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jun 25, 2024
ghstack-source-id: e117e6adfa0bf025c6a7a335144b9299dd4ffd68
Pull Request resolved: #30096
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jun 25, 2024
ghstack-source-id: 7676763e09a7f60c8ff50de4843a3f00b1fb049d
Pull Request resolved: #30096
@react-sizebot
Copy link

react-sizebot commented Jun 25, 2024

Comparing: 708d8f8...e1e6edd

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.93 kB 497.93 kB = 89.26 kB 89.25 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.75 kB 502.75 kB = 89.96 kB 89.96 kB
facebook-www/ReactDOM-prod.classic.js = 597.10 kB 597.10 kB = 105.31 kB 105.31 kB
facebook-www/ReactDOM-prod.modern.js = 571.44 kB 571.44 kB = 101.24 kB 101.24 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Generated by 🚫 dangerJS against e1e6edd

[ghstack-poisoned]
poteto added a commit that referenced this pull request Jun 25, 2024
ghstack-source-id: cdc514531325d7cea604d11f8cdeb67f64fd5a66
Pull Request resolved: #30096
Copy link
Contributor

@josephsavona josephsavona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine we have consensus on this but we should check

[ghstack-poisoned]
poteto added a commit that referenced this pull request Jun 25, 2024
ghstack-source-id: 303d20786812433dd06668f7078c1e59cd848d3c
Pull Request resolved: #30096
@@ -1,6 +1,6 @@
# [React](https://react.dev/) · [![GitHub license](https://img.shields.io/badge/license-MIT-blue.svg)](https://github.com/facebook/react/blob/main/LICENSE) [![npm version](https://img.shields.io/npm/v/react.svg?style=flat)](https://www.npmjs.com/package/react) [![CircleCI Status](https://circleci.com/gh/facebook/react.svg?style=shield)](https://circleci.com/gh/facebook/react) [![PRs Welcome](https://img.shields.io/badge/PRs-welcome-brightgreen.svg)](https://legacy.reactjs.org/docs/how-to-contribute.html#your-first-pull-request)

React is a JavaScript library for building user interfaces.
React is a JavaScript library for building web and native user interfaces.
Copy link
Member

@rickhanlonii rickhanlonii Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tagline on the homepage is "The library for web and native user interfaces", seems good to match that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
React is a JavaScript library for building web and native user interfaces.
The library for building web and native user interfaces.

@@ -1,6 +1,6 @@
# [React](https://react.dev/) · [![GitHub license](https://img.shields.io/badge/license-MIT-blue.svg)](https://github.com/facebook/react/blob/main/LICENSE) [![npm version](https://img.shields.io/npm/v/react.svg?style=flat)](https://www.npmjs.com/package/react) [![CircleCI Status](https://circleci.com/gh/facebook/react.svg?style=shield)](https://circleci.com/gh/facebook/react) [![PRs Welcome](https://img.shields.io/badge/PRs-welcome-brightgreen.svg)](https://legacy.reactjs.org/docs/how-to-contribute.html#your-first-pull-request)

React is a JavaScript library for building user interfaces.
React is a JavaScript library for building web and native user interfaces.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
React is a JavaScript library for building web and native user interfaces.
The library for building web and native user interfaces.

[ghstack-poisoned]
poteto added a commit that referenced this pull request Jun 25, 2024
ghstack-source-id: c1f22d6f43e7ff2ebf91b920e194221b1f5245d9
Pull Request resolved: #30096
@poteto
Copy link
Member Author

poteto commented Jun 25, 2024

Oh I wasn't actually planning on landing this, I just wanted to test to make sure I didn't break CI

[ghstack-poisoned]
poteto added a commit that referenced this pull request Jun 26, 2024
ghstack-source-id: 66b3d3a1588ce494829fe4de2ce466049e7f0b46
Pull Request resolved: #30096
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jun 26, 2024
ghstack-source-id: c21ca2ad85d5435c8916a1e3aeca289f501791a0
Pull Request resolved: #30096
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jun 26, 2024
ghstack-source-id: f53275a00bd4ce803e375986597726cfedb6ba26
Pull Request resolved: #30096
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jun 26, 2024
ghstack-source-id: ef025976f0cfddb4799623dcd9acdca8f61cf2f1
Pull Request resolved: #30096
@poteto poteto closed this Jul 26, 2024
@poteto poteto deleted the gh/poteto/31/head branch July 26, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants