Update constraint degree checks #305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: make degree check into a degree bound check feat: make degree check into a degree bound check feat: make degree check into a degree bound check
Al-Kindi-0
commented
Sep 5, 2024
Comment on lines
280
to
282
| self.trace_len() / 2 + 1, | ||
| n | ||
| ); |
There was a problem hiding this comment.
exemption points should probably be removed as well (i.e., fixed to always be 1)
|
I have removed now constraint degree from the code base. I personally don't like the result as it is not straightforward to know if the max degree of the (constraints of the) AIR is chosen correctly. Moreover, even in debug mode, I am not sure we can efficiently test this and hence the only way to know that this is the case is to wait for verification to not pass. Note also that this not polished in some places. |
|
Closing this in favor of #311 since it seems that having degree constraints is better than not having them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relaxes the constraint degree checks so that they become degree bounds checks instead of degree equality checks.