Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update constraint degree checks #311

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Update constraint degree checks #311

merged 1 commit into from
Sep 12, 2024

Conversation

Al-Kindi-0
Copy link
Contributor

Same as #305

This PR relaxes the constraint degree checks so that they become degree bounds checks instead of degree equality checks.

@Al-Kindi-0 Al-Kindi-0 mentioned this pull request Sep 11, 2024
Closed
irakliyk
irakliyk approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

This was only an issue during proof generation, right? During verification the moved away from strict equality checks a while back, I think.

@irakliyk irakliyk merged commit c146b4b into facebook:logup-gkr Sep 12, 2024
8 checks passed
@Al-Kindi-0
Copy link
Contributor Author

Looks good! Thank you!

This was only an issue during proof generation, right? During verification the moved away from strict equality checks a while back, I think.

That is indeed the case.

@Al-Kindi-0 Al-Kindi-0 deleted the al-update-degree-checks-simple branch September 12, 2024 07:45
@Al-Kindi-0 Al-Kindi-0 restored the al-update-degree-checks-simple branch September 12, 2024 08:49
@Al-Kindi-0 Al-Kindi-0 mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irakliyk irakliyk irakliyk approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Al-Kindi-0 @irakliyk @facebook-github-bot