-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIP-120] DAO Vote: PCVGuardian v3 #952
Closed
+915
−422
Closed
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
04c43b8
Update PCVGuardian to v3 and add forge tests
eswak 5d37dbd
tom's review
eswak 8546f7b
Merge remote-tracking branch 'origin/develop' into feat/pcvguardian-v3
eswak 915d275
rename fixture addresses & fix podexecutor unit tests
eswak 1dbaf4b
Update PCVGuardian to v3 and add forge tests
eswak 531415d
tom's review
eswak 9428149
PCVGuardian v3: remove pauseAfter param
eswak 5508ba7
reorder proposals
eswak 15374db
Merge branch 'feat/pcvguardian-v3' into qol/forge-fixture-rename
eswak fef615c
finish resolving merge conflicts
eswak 283adc1
Merge pull request #957 from fei-protocol/qol/forge-fixture-rename
eswak b074e98
Merge remote-tracking branch 'origin/develop' into feat/pcvguardian-v3
eswak f59d04b
klob's review
eswak 8752fb3
attempt to make diff more friendly
eswak ce69cf3
Merge remote-tracking branch 'origin/develop' into feat/pcvguardian-v3
eswak 4787aeb
tom's review
eswak f0c0444
Merge remote-tracking branch 'origin/develop' into feat/pcvguardian-v3
eswak a8ee388
Update pcv_guardian_v3 to be executed by DAO
eswak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Update pcv_guardian_v3 to be executed by DAO
commit a8ee388afaf1508839757057665900368215723b
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Being paranoid I would probably make sure that we can move funds here using the newly deployed pcvGuardianV3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok