Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with GitHub API Error (404) #21

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Conversation

howardbaik
Copy link
Contributor

@howardbaik howardbaik commented Nov 17, 2023

I used purrr::possibly() to handle calls that throw an error message. For those calls, this sets the value to be "Not Found".

NOTE: Even with this change, I still get this warning:

Warning message:
In rep(no, length.out = len) : 'x' is NULL so the result will be NULL

I think this might have to do with ifelse(). Further investigation to be had.

@cansavvy
Copy link
Collaborator

@howardbaek thanks for this add! I'm definitely going to look into this. But probably not until Monday. Take a look at the Google analytics pr. I think that should have less bugs 🤞 and if so you can start building the dashboard around that while I address GitHub bugs.

@cansavvy
Copy link
Collaborator

Ah now I understand. I did fix some of these thing but the fixes are on #16

Copy link
Collaborator

@cansavvy cansavvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks

@cansavvy cansavvy merged commit fcdfa79 into cansavvy/github Nov 19, 2023
@cansavvy cansavvy deleted the howardbaek/github-fix branch November 19, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants