lint: refactor to more current patterns

Change from indexed array access to for/of syntax.

Signed-off-by: Chris. Webster <[email protected]>

lib/commit-lint.ts

@@ -106,15 +106,13 @@ export class LintCommit {
             this.block("The first line must be separated from the rest by an empty line");
         }
 
-        for (let i = 1; i < this.lines.length; i++) {
-            if (this.lines[i].length > this.maxColumns &&
+        for (const line of this.lines) {
+            if (line.length > this.maxColumns &&
                 // Allow long lines if prefixed with whitespace (ex. quoted error messages)
-                !this.lines[i].match(/^\s+/) &&
-                // Allow long lines if they cannot be wrapped at some
-                // white-space character, e.g. URLs. To allow a short
-                // preamble such as `ref [1] <URL>` lines, we skip the
-                // first 10 (arbitrary) characters.
-                this.lines[i].slice(10).match(/\s/)) {
+                !line.match(/^\s+/) &&
+                // Allow long lines if they cannot be wrapped at some white-space character, e.g. URLs. To allow a
+                // short preamble such as `ref [1] <URL>` lines, we skip the first 10 (arbitrary) characters.
+                line.slice(10).match(/\s/)) {
                 this.block(`Lines in the body of the commit messages should be wrapped between 60 and ${
                         this.maxColumns} characters.\nIndented lines, and lines without whitespace, are exempt`);
                 break;