fix(device_info_plus)!: return type of isPhysicalDevice as boolean for ios

[muhib349]

Description

For iOS devices isPhysicalDevice was returned as String from native platform, now it is returning boolean from native platform.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR.

e.g.

• *Fix [Bug]: Why 'isPhysicalDevice' type as String on iOS? It's bool on Android. #2483 *
• Related N/A

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I titled the PR using Conventional Commits.
• I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
• All existing and new tests are passing.
• The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

• Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
• No, this is not a breaking change.

[miquelbeltran]

Objective-C is weird :)

[muhib349]

It was my first time writing code in Objective-C, from a Java and Android background. Undoubtedly, it was horrible for me.

[miquelbeltran]

Thanks! Change LGTM, but I want to run it before approval, that will take a day or two.

[miquelbeltran]

I could test it now and it works as expected!

Just curious, why did you need to use [NSNumber numberWithBool ..]? Could not be possible to just pass the boolean value in the result map?

[miquelbeltran]

@vbuberen I changed the title to fix(device_info_plus)!: ... to mark it as breaking change.

[muhib349]

I could test it now and it works as expected!

Just curious, why did you need to use [NSNumber numberWithBool ..]? Could not be possible to just pass the boolean value in the result map?

I tried to do so, however, Bool is a primitive data type and we couldn't pass any primitive data types to the map object. That's why I used NSNumber to represent boolean.

[vbuberen]

I could test it now and it works as expected!

This change looks good to me as well. @miquelbeltran are you Ok with merging this change?

[miquelbeltran]

All good from my side as well @vbuberen