Resource pool status

[jameshcorbett]

Problem: the FluxionResourcePoolV1 does not support setting
vertex status. However, some resources, such as rabbits, should
be initialized as down, and are only known to Fluxion through
JGF produced by the FluxResourcePool class.

Add a 'status' parameter to the FluxionResourcePoolV1 constructor,
with a default of 'up' to maintain backwards compatibility.

It sounds like there's a chance we'll change the JGF reader's default to 'down' in which case we'd want to change the behavior of the ResourceGraph class as well, I think.

[milroy]

This PR is looking good overall, but the test isn't currently being run.

You'll need to add the test to CMakeLists here:

flux-sched/t/CMakeLists.txt

Line 88 in d51c81f

)

and then make a simple sharness test (i.e. t10001-resourcegraph.t) that runs t10001-resourcegraph.py like this:

flux-sched/t/t3301-system-latestart.t

Line 31 in d51c81f

test_expect_success 'flux resource list works' '

[milroy]

It sounds like there's a chance we'll change the JGF reader's default to 'down' in which case we'd want to change the behavior of the ResourceGraph class as well, I think.

I think we'll end up leaving the JGF reader's default to up to avoid having to change a lot of the current sharness tests.

[jameshcorbett]

You'll need to add the test to CMakeLists here:

Done and pushed!

and then make a simple sharness test (i.e. t10001-resourcegraph.t) that runs t10001-resourcegraph.py like this:

How come? The python test outputs TAP already, since I copied the pycotap package over from flux-core.

[milroy]

How come? The python test outputs TAP already, since I copied the pycotap package over from flux-core.

You're right. I messed up the PATH in my testing which confused me about how sharness was executing the test.

[milroy]

LGTM! This is ready to be merged.

[jameshcorbett]

Thanks! Setting MWP

[codecov]

Codecov Report

Merging #1123 (801329f) into master (d51c81f) will decrease coverage by 0.5%.
The diff coverage is 83.3%.

Additional details and impacted files

@@           Coverage Diff            @@
##           master   #1123     +/-   ##
========================================
- Coverage    70.1%   69.7%   -0.5%     
========================================
  Files          90      94      +4     
  Lines       12264   12723    +459     
========================================
+ Hits         8605    8868    +263     
- Misses       3659    3855    +196     

Files	Coverage Δ
src/python/fluxion/resourcegraph/V1.py	78.0% <83.3%> (ø)

... and 3 files with indirect coverage changes