Build python wheels #171
Merged
Build python wheels #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amacneil
force-pushed
the
adrian/python-sdk-wheels
branch
from
4d7eeb8 to
a7b50cb
Compare
amacneil
force-pushed
the
adrian/python-sdk-wheels
branch
from
1b3def0 to
c5e8ebb
Compare
amacneil
force-pushed
the
adrian/python-sdk-wheels
branch
from
ed91636 to
062178d
Compare
amacneil
force-pushed
the
adrian/python-sdk-wheels
branch
from
209c798 to
8211be3
Compare
amacneil
force-pushed
the
adrian/python-sdk-wheels
branch
from
8211be3 to
ce82c25
Compare
gasmith
reviewed
Feb 3, 2025
| @@ -30,6 +30,7 @@ fn compile_protos() { | |||
| )); | |||
| } | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
TLDR yes - for examplearduino/setup-protoc doesn't support windows and official protoc binaries for windows are not available.
IMO we should remove protoc from the build step, but I didn't want to do that here. We can either commit the compiled protos to git (like we're doing with all other libraries in this repo), or even better we can remove proto serialization from the python sdk entirely and let rust handle it.
https://linear.app/foxglove/issue/FG-10358/spike-python-protobuf-serialization-in-rust
gasmith
reviewed
Feb 3, 2025
gasmith
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
None
Docs
None
Description
Our upcoming python sdk uses maturin to depend on rust code. Most python users will want to install from wheels, containing the precompiled rust binaries.
This PR adds support for compiling wheels on 86 different operating systems and architectures.
Python jobs are moved to a separate workflow because
ci.ymlwas getting out of hand. We could potentially separate the remaining ROS + Rust + TypeScript workflows into separate files in the future too.