edge-controller: configure primary site mode through values #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-rms
force-pushed
the
jrms/edge-set-primary-site-mode
branch
from
c2a9930 to
46daf44
Compare
james-rms
force-pushed
the
jrms/edge-set-primary-site-mode
branch
from
46daf44 to
40fb64a
Compare
bryfox
approved these changes
Nov 12, 2024
charts/edge-site/values.yaml
Outdated
| # Values: "self-managed", "hosted" | ||
| primarySiteMode: self-managed | ||
| # The cloud provider where the self-managed primary site inbox bucket lives. | ||
| # If `primarySiteMode` is set to `hosted`, these values are ignored. |
There was a problem hiding this comment.
It might be worth saying "this value" is ignored, and repeating it for the bucket name below... for clarity and future-proofing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Docs
https://github.com/foxglove/docs/pull/481
Description
It's possible to use an edge controller with a hosted primary site, but right now users don't have a good way to configure that. This PR plumbs through a configuration variable for this.