add volume, image, init customization support to helm charts #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofuture
changed the title
wimagguc
reviewed
Dec 10, 2024
charts/edge-site/values.yaml
Outdated
| @@ -59,3 +60,8 @@ edgeController: | |||
| podAnnotations: {} | |||
| serviceLabels: {} | |||
| env: [] | |||
| # Customize init containers here | |||
There was a problem hiding this comment.
Nit: I don't find these comments particularly helpful
There was a problem hiding this comment.
Thinking about this further: would it be useful to add a short section to our docs on supporting custom CA chains?
sofuture
force-pushed
the
jz/init-containers-and-volumes
branch
2 times, most recently
from
b7b96c4 to
3664694
Compare
sofuture
force-pushed
the
jz/init-containers-and-volumes
branch
from
3664694 to
b369b77
Compare
wimagguc
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
edge-site: add support extra custom volumes, init containers and image names
primary-site: add support extra custom volumes, init containers and image names
Docs
None
Description
Add support for custom volumes and init containers in all Helm charts. Also move image names to a chart value.
This should allow end users to specify custom credentials and workflows enabling more advanced usecases like adding a trusted certificate chain.
Fixes: FG-9734