Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

primary-site: default HTTP/HTTPS proxy egress to disabled #109

Merged
merged 3 commits into from
Dec 12, 2024
Merged

primary-site: default HTTP/HTTPS proxy egress to disabled #109

merged 3 commits into from
Dec 12, 2024

Conversation

sofuture
Copy link
Contributor

Changelog

primary-site:

  • fix: default HTTP/HTTPS proxy egress to disabled

Docs

None

Description

Default HTTP/HTTPS proxy egress to disabled.

@sofuture sofuture changed the title Jz/fix proxy default primary-site: default HTTP/HTTPS proxy egress to disabled Dec 12, 2024
defunctzombie
defunctzombie approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@defunctzombie defunctzombie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems better - noProxy is weird to me and "appropriate values" is vague if we expect something specific (like comma separated lists for noProxy).

@sofuture sofuture merged commit 2ce1a1a into main Dec 12, 2024
1 check passed
@sofuture sofuture deleted the jz/fix-proxy-default branch December 12, 2024 15:55
@sofuture
Copy link
Contributor Author

The names of these proxy variables are all convention 🙃 There's no spec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@defunctzombie defunctzombie defunctzombie approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sofuture @defunctzombie